Skip to content

Refactored interpolation method type declaration #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dydavidkim merged 4 commits into from
Oct 6, 2022
Merged

Refactored interpolation method type declaration #54

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60343aa
Implementation of preprocessing image resizing layer
dydavidkim Sep 29, 2022
02df8cd
Updating image preprocessing test file to include approved usage of C…
dydavidkim Sep 29, 2022
28ace0a
refactored interpolation type declaration
dydavidkim Oct 6, 2022
bde6fa1
Merge branch 'resizing' into resizing
dydavidkim Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tfjs-layers/src/layers/preprocessing/image_resizing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ import {getExactlyOneShape} from '../../utils/types_utils'; //, getExactlyOneTe

// tf methods unimplemented in tfjs: 'bicubic', 'area', 'lanczos3', 'lanczos5',
// 'gaussian', 'mitchellcubic'
const INTERPOLATION_METHODS = new Set(['bilinear', 'nearest']);
const INTERPOLATION_KEYS = ['bilinear', 'nearest'] as const;
const INTERPOLATION_METHODS = new Set(INTERPOLATION_KEYS);
type InterpolationType = typeof INTERPOLATION_KEYS[number];

export declare interface ResizingArgs extends LayerArgs {
height: number;
width: number;
interpolation?: string; // default = 'bilinear';
cropToAspectRatio?: boolean; // default = false;
interpolation?: InterpolationType; // default = 'bilinear';
cropToAspectRatio?: boolean; // default = false;
}

/**
Expand All @@ -39,7 +41,7 @@ export class Resizing extends Layer {
private readonly height: number;
private readonly width: number;
// method of interpolation to be used; default = "bilinear";
private readonly interpolation: string;
private readonly interpolation: InterpolationType;
// toggle whether the aspect ratio should be preserved; default = false;
private readonly cropToAspectRatio: boolean;

Expand Down