Skip to content

[BREAKING] Make extensions internal #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
verdie-g wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[BREAKING] Make extensions internal #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
445aa0c
[BREAKING] Make StringExtensions internal
verdie-g Aug 18, 2025
b46ebc2
Make other extensions internal
verdie-g Aug 18, 2025
3b773fd
Remove from public API
verdie-g Aug 19, 2025
764fca8
Make MathUtils internal
verdie-g Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions ClickHouse.Driver/PublicAPI/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,6 @@ ClickHouse.Driver.Utility.CompressedContent
ClickHouse.Driver.Utility.CompressedContent.CompressedContent(System.Net.Http.HttpContent content, System.Net.DecompressionMethods compressionMethod) -> void
ClickHouse.Driver.Utility.ConnectionExtensions
ClickHouse.Driver.Utility.DataReaderExtensions
ClickHouse.Driver.Utility.DictionaryExtensions
ClickHouse.Driver.Utility.EnumerableExtensions
ClickHouse.Driver.Utility.MathUtils
ClickHouse.Driver.Utility.StringExtensions
override ClickHouse.Driver.ADO.ClickHouseCommand.Cancel() -> void
override ClickHouse.Driver.ADO.ClickHouseCommand.CommandText.get -> string
override ClickHouse.Driver.ADO.ClickHouseCommand.CommandText.set -> void
Expand Down Expand Up @@ -320,8 +316,6 @@ static ClickHouse.Driver.Numerics.ClickHouseDecimal.operator <=(ClickHouse.Drive
static ClickHouse.Driver.Numerics.ClickHouseDecimal.operator ==(ClickHouse.Driver.Numerics.ClickHouseDecimal left, ClickHouse.Driver.Numerics.ClickHouseDecimal right) -> bool
static ClickHouse.Driver.Numerics.ClickHouseDecimal.operator >(ClickHouse.Driver.Numerics.ClickHouseDecimal left, ClickHouse.Driver.Numerics.ClickHouseDecimal right) -> bool
static ClickHouse.Driver.Numerics.ClickHouseDecimal.operator >=(ClickHouse.Driver.Numerics.ClickHouseDecimal left, ClickHouse.Driver.Numerics.ClickHouseDecimal right) -> bool
static ClickHouse.Driver.Types.DateTimeConversions.FromUnixTimeDays(int days) -> System.DateTime
static ClickHouse.Driver.Types.DateTimeConversions.ToUnixTimeDays(this System.DateTimeOffset dto) -> int
static ClickHouse.Driver.Types.Grammar.Parser.Parse(string input) -> ClickHouse.Driver.Types.Grammar.SyntaxTreeNode
static ClickHouse.Driver.Types.Grammar.Tokenizer.GetTokens(string input) -> System.Collections.Generic.IEnumerable<string>
static ClickHouse.Driver.Utility.CommandExtensions.AddParameter(this ClickHouse.Driver.ADO.ClickHouseCommand command, string parameterName, object parameterValue) -> ClickHouse.Driver.ADO.Parameters.ClickHouseDbParameter
Expand All @@ -331,21 +325,7 @@ static ClickHouse.Driver.Utility.ConnectionExtensions.ExecuteReaderAsync(this Sy
static ClickHouse.Driver.Utility.ConnectionExtensions.ExecuteScalarAsync(this System.Data.Common.DbConnection connection, string sql) -> System.Threading.Tasks.Task<object>
static ClickHouse.Driver.Utility.ConnectionExtensions.ExecuteStatementAsync(this System.Data.Common.DbConnection connection, string sql) -> System.Threading.Tasks.Task<int>
static ClickHouse.Driver.Utility.DataReaderExtensions.GetColumnNames(this System.Data.IDataReader reader) -> string[]
static ClickHouse.Driver.Utility.DictionaryExtensions.Set<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> dictionary, TKey key, TValue value) -> void
static ClickHouse.Driver.Utility.DictionaryExtensions.TryAdd<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> dictionary, TKey key, TValue value) -> bool
static ClickHouse.Driver.Utility.EnumerableExtensions.BatchRented<T>(this System.Collections.Generic.IEnumerable<T> enumerable, int batchSize) -> System.Collections.Generic.IEnumerable<(T[], int)>
static ClickHouse.Driver.Utility.EnumerableExtensions.Deconstruct<T>(this System.Collections.Generic.IList<T> list, out T first, out T second) -> void
static ClickHouse.Driver.Utility.EnumerableExtensions.Deconstruct<T>(this System.Collections.Generic.IList<T> list, out T first, out T second, out T third) -> void
static ClickHouse.Driver.Utility.MathUtils.ShiftDecimalPlaces(long value, int places) -> long
static ClickHouse.Driver.Utility.MathUtils.ToPower(int value, int power) -> long
static ClickHouse.Driver.Utility.StringExtensions.EncloseColumnName(this string str) -> string
static ClickHouse.Driver.Utility.StringExtensions.Escape(this string str) -> string
static ClickHouse.Driver.Utility.StringExtensions.QuoteDouble(this string str) -> string
static ClickHouse.Driver.Utility.StringExtensions.QuoteSingle(this string str) -> string
static ClickHouse.Driver.Utility.StringExtensions.ReplaceMultipleWords(this string input, System.Collections.Generic.Dictionary<string, string> replacements) -> string
static ClickHouse.Driver.Utility.StringExtensions.ToSnakeCase(this string str) -> string
static readonly ClickHouse.Driver.Constraints.DBDefault.Value -> ClickHouse.Driver.Constraints.DBDefault
static readonly ClickHouse.Driver.Types.DateTimeConversions.DateTimeEpochStart -> System.DateTime
virtual ClickHouse.Driver.ADO.ClickHouseConnection.SupportedFeatures.get -> ClickHouse.Driver.ADO.Feature
virtual ClickHouse.Driver.ADO.Readers.ClickHouseDataReader.GetDateTimeOffset(int ordinal) -> System.DateTimeOffset
ClickHouse.Driver.ADO.Adapters.ClickHouseDataAdapter
Expand Down
1 change: 0 additions & 1 deletion ClickHouse.Driver/PublicAPI/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ ClickHouse.Driver.ADO.QueryStats.QueryStats(ClickHouse.Driver.ADO.QueryStats ori
ClickHouse.Driver.Copy.ClickHouseBulkCopy.MemoryStreamManager.get -> Microsoft.IO.RecyclableMemoryStreamManager
ClickHouse.Driver.Copy.ClickHouseBulkCopy.MemoryStreamManager.init -> void
ClickHouse.Driver.Diagnostic.ClickHouseDiagnosticsOptions
ClickHouse.Driver.Types.DateTimeConversions
ClickHouse.Driver.Types.Grammar.Parser
ClickHouse.Driver.Types.Grammar.SyntaxTreeNode
ClickHouse.Driver.Types.Grammar.SyntaxTreeNode.ChildNodes.get -> System.Collections.Generic.IList<ClickHouse.Driver.Types.Grammar.SyntaxTreeNode>
Expand Down
1 change: 0 additions & 1 deletion ClickHouse.Driver/PublicAPI/net8.0/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ ClickHouse.Driver.IClickHouseDataSource.OpenConnection() -> ClickHouse.Driver.IC
ClickHouse.Driver.IClickHouseDataSource.OpenConnectionAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<ClickHouse.Driver.IClickHouseConnection>
override ClickHouse.Driver.ADO.ClickHouseConnectionFactory.CreateDataSource(string connectionString) -> System.Data.Common.DbDataSource
override ClickHouse.Driver.ADO.ClickHouseDataSource.ConnectionString.get -> string
static readonly ClickHouse.Driver.Types.DateTimeConversions.DateOnlyEpochStart -> System.DateOnly
static Microsoft.Extensions.DependencyInjection.ClickHouseServiceCollectionExtensions.AddClickHouseDataSource(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, string connectionString, System.Net.Http.IHttpClientFactory httpClientFactory, string httpClientName = "", Microsoft.Extensions.DependencyInjection.ServiceLifetime connectionLifetime = Microsoft.Extensions.DependencyInjection.ServiceLifetime.Transient, Microsoft.Extensions.DependencyInjection.ServiceLifetime dataSourceLifetime = Microsoft.Extensions.DependencyInjection.ServiceLifetime.Singleton, object serviceKey = null) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
static Microsoft.Extensions.DependencyInjection.ClickHouseServiceCollectionExtensions.AddClickHouseDataSource(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, string connectionString, System.Net.Http.HttpClient httpClient = null, Microsoft.Extensions.DependencyInjection.ServiceLifetime connectionLifetime = Microsoft.Extensions.DependencyInjection.ServiceLifetime.Transient, Microsoft.Extensions.DependencyInjection.ServiceLifetime dataSourceLifetime = Microsoft.Extensions.DependencyInjection.ServiceLifetime.Singleton, object serviceKey = null) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
static Microsoft.Extensions.DependencyInjection.ClickHouseServiceCollectionExtensions.AddClickHouseDataSource(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Func<System.IServiceProvider, object, ClickHouse.Driver.ADO.ClickHouseDataSource> dataSourceFactory, Microsoft.Extensions.DependencyInjection.ServiceLifetime connectionLifetime = Microsoft.Extensions.DependencyInjection.ServiceLifetime.Transient, Microsoft.Extensions.DependencyInjection.ServiceLifetime dataSourceLifetime = Microsoft.Extensions.DependencyInjection.ServiceLifetime.Singleton, object serviceKey = null) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
2 changes: 1 addition & 1 deletion ClickHouse.Driver/Types/AbstractDateTimeType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ClickHouse.Driver.Types;

public static class DateTimeConversions
internal static class DateTimeConversions
{
public static readonly DateTime DateTimeEpochStart = DateTimeOffset.FromUnixTimeSeconds(0).UtcDateTime;

Expand Down
2 changes: 1 addition & 1 deletion ClickHouse.Driver/Utility/DataReaderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace ClickHouse.Driver.Utility;

public static class DataReaderExtensions
internal static class DataReaderExtensions
{
public static string[] GetColumnNames(this IDataReader reader)
{
Expand Down
2 changes: 1 addition & 1 deletion ClickHouse.Driver/Utility/DictionaryExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace ClickHouse.Driver.Utility;

public static class DictionaryExtensions
internal static class DictionaryExtensions
{
public static bool TryAdd<TKey, TValue>(this IDictionary<TKey, TValue> dictionary, TKey key, TValue value)
{
Expand Down
2 changes: 1 addition & 1 deletion ClickHouse.Driver/Utility/EnumerableExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace ClickHouse.Driver.Utility;

public static class EnumerableExtensions
internal static class EnumerableExtensions
{
public static void Deconstruct<T>(this IList<T> list, out T first, out T second)
{
Expand Down
2 changes: 1 addition & 1 deletion ClickHouse.Driver/Utility/MathUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace ClickHouse.Driver.Utility;

public static class MathUtils
internal static class MathUtils
{
public static long ToPower(int value, int power)
{
Expand Down
2 changes: 1 addition & 1 deletion ClickHouse.Driver/Utility/StringExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace ClickHouse.Driver.Utility;

public static class StringExtensions
internal static class StringExtensions
{
public static string Escape(this string str) => str.Replace("\\", "\\\\").Replace("\'", "\\\'").Replace("\n", "\\n").Replace("\t", "\\t");

Expand Down