fix jacobian terms related to dpdqt #4139
Open
+22
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Makes the jacobian terms that related to dp/dqt more consistent with the updraft. These includes ∂ᶠu₃_err_∂ᶜρq_tot and ∂ᶠᶜρe_tot_err_∂ᶜρq_tot. Also fixes a bug we had before in ∂ᶠᶜρe_tot_err_∂ᶜρq_tot.
I think there might be a small error in ∂ᶠᶜρe_tot_err_∂ᶜρ too. I will look at that next.
To-do
Content