Skip to content

Conversation

vballu
Copy link
Contributor

@vballu vballu commented Sep 3, 2025

…in the .gitmodules using ssh key

📝 What does this PR do?

Add a tips: explain how to use private submodule without exposing credentials in .gitmodules


🧪 Type of Change

  • ⚠️ Bug fix
  • 📅 Changelog update
  • 📚 Documentation update
  • ✨ New content/feature
  • 🔧 Technical/maintenance

✅ Quick Checklist


👥 Reviewers

@CleverCloud/reviewers

Copy link

github-actions bot commented Sep 3, 2025

✅ Review app deployed

Check how your changes look like!

ℹ️ Name 🔗 Infos & links
🌱 Latest deployed commit 242af5d
👁️ Preview https://documentation-PR-775.cleverapps.io/developers

@davlgd
Copy link
Collaborator

davlgd commented Sep 3, 2025

IMHO it's not a "tips & tricks" thing, it's more a part of how deployment works with Git Submodules. Also:

  • Don't use "Please" in instructions
  • Prefer markdown info notice rather than theme specific shortcodes

@vballu
Copy link
Contributor Author

vballu commented Sep 3, 2025

IMHO it's not a "tips & tricks" thing, it's more a part of how deployment works with Git Submodules. Also:

  • Don't use "Please" in instructions
  • Prefer markdown info notice rather than theme specific shortcodes

@davlgd , do you think https://www.clever.cloud/developers/doc/ci-cd/ would be a better place for that explanation?

@davlgd
Copy link
Collaborator

davlgd commented Sep 3, 2025

@davlgd , do you think https://www.clever.cloud/developers/doc/ci-cd/ would be a better place for that explanation?

Nope, it's more how to use GitHub/GitLab to deploy through our tools helping on that. I think it should be in a develop/git.md page with a part dedicated to this, with other git related information (for example git full clone or stuff like that).

Move your changes in such a new page and I'll check/edit during review, and we'll see how to complete it in this PR or another depending on how much info we have to add and merge this fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants