Improve Grid #92
Merged
Improve Grid #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other misc changes
update mapToMatrix and correct parameter name
rename margin method
ghzdude
force-pushed
the
gh/improve-grid
branch
from
678230c to
e50030c
Compare
brachy84
approved these changes
Nov 9, 2024
YannickMG
pushed a commit
to GTNewHorizons/ModularUI2
that referenced
this pull request
Dec 27, 2024
* add method overload + small improvements * add new method other misc changes * simplify code * add nullability guards and checks update mapToMatrix and correct parameter name * don't set element margin to 2 rename margin method * simplify even more * one more nullability guard (cherry picked from commit d296c8d)
serenibyss
pushed a commit
to GTNewHorizons/ModularUI2
that referenced
this pull request
Dec 27, 2024
* add method overload + small improvements * add new method other misc changes * simplify code * add nullability guards and checks update mapToMatrix and correct parameter name * don't set element margin to 2 rename margin method * simplify even more * one more nullability guard (cherry picked from commit d296c8d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a few methods to Grid to make configuring the matrix easier
adds some nullability checks and guards
removes setting the min element margin in constructor
rename
margin(int all)->minElementMargin(int all)