Textfield improvements #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handler test prevents invalid chars from removing textbox
This is the same behavior as of MUI1. Also Windows uses 530 ms by default.
The implementation is somewhat dirty, but I can't think of better way. I renamed constant E to NAPIER, as it clashes with E notation. I don't think someone will use this anyway.
Printing to log might make people think it's bug in code. This feature can be used for indicator of what's wrong with the use input. This also stops function construction from failing silently.
I believe this is better than silently dividing by 1.
It's not game-breaking fatal error anyway.
Former defaultValue is gone, because 1. It's set by onInit 2. It's better to restore the last value rather than something supposed to be default
This reverts commit 8e00147.
This reverts commit 580683b.
brachy84
approved these changes
Oct 4, 2024
YannickMG
referenced
this pull request
in GTNewHorizons/ModularUI2
Dec 27, 2024
* Allow focusing on text field upon GUI open * Remove selected chars on key type or paste Handler test prevents invalid chars from removing textbox * Prevent § from being pasted * Shorten cursor blink rate to 0.5s This is the same behavior as of MUI1. Also Windows uses 530 ms by default. * Parse thousand separator * Clear text on right click * Add support for suffixes and E notation The implementation is somewhat dirty, but I can't think of better way. I renamed constant E to NAPIER, as it clashes with E notation. I don't think someone will use this anyway. * Allow retrieving parse fail message Printing to log might make people think it's bug in code. This feature can be used for indicator of what's wrong with the use input. This also stops function construction from failing silently. * Allow setting default number * Make division by zero throw exception I believe this is better than silently dividing by 1. * Add config to restore the last text if ESC key is pressed * Handle cases failed to parse function * Catch all the exceptions It's not game-breaking fatal error anyway. * Split into text field and numeric field Former defaultValue is gone, because 1. It's set by onInit 2. It's better to restore the last value rather than something supposed to be default * Rename TextFieldWidget -> OneLineTextField StringTextFieldWidget -> TextFieldWidget * Dirty solution for comma as thousand separator * Rewrite the way E notation is handled * Revert "Rename" This reverts commit 8e00147. * Revert "Split into text field and numeric field" This reverts commit 580683b. (cherry picked from commit 53f305e)
serenibyss
referenced
this pull request
in GTNewHorizons/ModularUI2
Dec 27, 2024
* Allow focusing on text field upon GUI open * Remove selected chars on key type or paste Handler test prevents invalid chars from removing textbox * Prevent § from being pasted * Shorten cursor blink rate to 0.5s This is the same behavior as of MUI1. Also Windows uses 530 ms by default. * Parse thousand separator * Clear text on right click * Add support for suffixes and E notation The implementation is somewhat dirty, but I can't think of better way. I renamed constant E to NAPIER, as it clashes with E notation. I don't think someone will use this anyway. * Allow retrieving parse fail message Printing to log might make people think it's bug in code. This feature can be used for indicator of what's wrong with the use input. This also stops function construction from failing silently. * Allow setting default number * Make division by zero throw exception I believe this is better than silently dividing by 1. * Add config to restore the last text if ESC key is pressed * Handle cases failed to parse function * Catch all the exceptions It's not game-breaking fatal error anyway. * Split into text field and numeric field Former defaultValue is gone, because 1. It's set by onInit 2. It's better to restore the last value rather than something supposed to be default * Rename TextFieldWidget -> OneLineTextField StringTextFieldWidget -> TextFieldWidget * Dirty solution for comma as thousand separator * Rewrite the way E notation is handled * Revert "Rename" This reverts commit 8e00147. * Revert "Split into text field and numeric field" This reverts commit 580683b. (cherry picked from commit 53f305e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit for more info.