Fix JEI Compat #62
Merged
Fix JEI Compat #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
reviewed
Jul 21, 2024
| private final List<ModularSlot> slots = new ArrayList<>(); | ||
| private final List<ModularSlot> shiftClickSlots = new ArrayList<>(); | ||
| private ContainerCustomizer containerCustomizer; | ||
| private ModularScreen modularScreen = null; |
Member
There was a problem hiding this comment.
This looks like it can cause a crash on server side.
Contributor
Author
There was a problem hiding this comment.
how exactly? JEI's transferRecipe() is only called on client side, and if it was called server side it would return false for the instanceof check
Contributor
Author
There was a problem hiding this comment.
nvm i think i see what you mean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JEI compat.
ModularScreen.getCurrent()never returns the correct screen because JEI's screen wrapper is the current screen at the time of callingtransferRecipe(), so a reference to theModularScreenis stored in the container to be retrieved and checked.