Skip to content

Fix ByteSyncValue not calling source setter #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brachy84 merged 1 commit into from
Apr 27, 2025
Merged

Fix ByteSyncValue not calling source setter #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/cleanroommc/modularui/value/sync/ByteSyncValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ public boolean updateCacheFromSource(boolean isFirstSync) {
}

@Override
public void write(PacketBuffer buffer) throws IOException {
public void write(PacketBuffer buffer) {
buffer.writeByte(getByteValue());
}

@Override
public void read(PacketBuffer buffer) throws IOException {
setByteValue(buffer.readByte(), false, false);
public void read(PacketBuffer buffer) {
setByteValue(buffer.readByte(), true, false);
}

@Override
Expand Down