Skip to content

Object Mapper Inverter #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brachy84 merged 15 commits into from
Oct 9, 2025
Merged

Object Mapper Inverter #339

brachy84 merged 15 commits into from
Oct 9, 2025

Conversation

@WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Oct 4, 2025 •
edited
Loading

changes in this PR:

  • Add an inverter to object mappers, so doing ie item % item('minecraft:clay') returns the String item('minecraft:clay').
  • implement this for a lot of Object Mappers - of Object Mappers in GroovyScript, only the Forestry Species one is not implemented (35/36).
    • add questionable conversion for thaumcraft crystals and alchemistry elements.
  • change parseOreDict from returning Result<IIngredient> to Result<OreDictIngredient>.
  • make fluid and liquid have the same builder methods instead of each missing some.
  • add a few more asGroovyCode methods.
  • change thermal compactorMode to use completerOfEnum.
  • fix preInit/mekanism.groovy using the wrong file (still using placeholdername)

@WaitingIdly WaitingIdly added the enhancement New feature or request label Oct 4, 2025
@WaitingIdly
use Iterable instead of Collection
6ce8aaf
@WaitingIdly
fix mekanism using wrong texture
30481c2
@WaitingIdly
Merge branch 'master' into object-mapper-inverter
76e9e29 
# Conflicts:
#	src/main/java/com/cleanroommc/groovyscript/mapper/ObjectMapperManager.java
brachy84
brachy84 requested changes Oct 9, 2025
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@brachy84 brachy84 merged commit 4367742 into CleanroomMC:master Oct 9, 2025
@WaitingIdly WaitingIdly deleted the object-mapper-inverter branch October 9, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WaitingIdly @brachy84