Filter Completions from Object Mappers #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
reviewed
Sep 21, 2025
src/main/java/net/prominic/groovyls/providers/CompletionProvider.java
Outdated
Show resolved
Hide resolved
WaitingIdly
approved these changes
Sep 22, 2025
brachy84
requested changes
Oct 4, 2025
Member
brachy84
left a comment
brachy84
left a comment
There was a problem hiding this comment.
Why are you creating a separate list? Why are you not filtering where the items are added?
brachy84
added
enhancement
Contributor
Author
Fixed in latest commit. |
WaitingIdly
reviewed
Oct 8, 2025
src/main/java/com/cleanroommc/groovyscript/server/Completions.java
Outdated
Show resolved
Hide resolved
brachy84
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters the completions coming from object mappers, so only the ones relevant are sent over lsp.
No APIs have been changed, so no incompatibilities should have been created.
I have not modified completions to filter for all, since this behaviour needs only to target object mapper completions.
This allows, for example, completion of
item(mapper for items from mods with a modid low in the alphabet in large modpacks.