Note Chisel Carving bug for registry replacement #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
requested changes
Sep 27, 2025
Comment on lines
101
to
102
| } catch (NullPointerException e) { | ||
| GroovyLog.get().exception("An exception occurred with chisel carving - possibly due to some other mod doing registry replacement.", e); |
Member
There was a problem hiding this comment.
Is there something the user can do to fix the crash? If no then it should just be an error. (And mention what the user is else supposed to do). Otherwise still display the fix message.
Collaborator
Author
There was a problem hiding this comment.
there is possibly something that could be done, depending on if the thing doing registry replacement is configurable, but as any mod could do this we cannot know if or how this could be fixed
Member
There was a problem hiding this comment.
Then the user is supposed to remove what they are currently doing? The message should say that,
brachy84
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR: