Ore Ingredient Changes #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
IOreDictsto use a collection instead of a list, and make it not extendIIngredient(other things could represent multiple oredicts).QUERYexamples (only one that exists prior to this PR was IE blueprint crafting molds).OreDictIngredientextendIngredientBaseinstead ofItemsIngredient, fixing caching issue.OreDictIngredientno longer cache itemstacks, which worsens performance. there is no good way to avoid this.OreDictWildcardIngredientviaore('*'), addOreDictMatcherIngredientviaoredict.getOres(~/.*/)*,sm*le, etc are valid oredict names, and so replacing any with the*character with a different object is incorrect. as such, we cannot use theoreObject Mapper for bothOreDictIngredientandOreDictWildcardIngredient.oredict.streamOreNames()for clearing and managing oredicts.