Skip to content

Conversation

@WaitingIdly
Copy link
Collaborator

changes in this PR:

  • GroovyScript is not compatible with Extended Crafting, and is only compatible with Extended Crafting: Nomifactory Edition. this updated the @Mod#dependencies with after:extendedcrafting@[1.6.0,); to ensure this is followed.
  • 1.5.6 is the last version of extended crafting, and 1.6.0 is the first version of the nomi fork.

reasoning:

  • the mixin ItemRecipeMakerMixin is written for Nomi, and the Compression Crafting compat errors outside of the Nomi version.
    • this is because base extended crafting has a return value of ArrayList for getRecipes, while nomi fork returns a List. this could be fixed via reflection.

test via adding this to dependencies.gradle:

runtimeOnly(rfg.deobf('curse.maven:cucumber-272335:2645867'))
runtimeOnly(rfg.deobf('curse.maven:extended-crafting-268387:2777071'))

related to #267

@WaitingIdly WaitingIdly added the bug Something isn't working label Apr 18, 2025
@brachy84 brachy84 merged commit 4a6b552 into CleanroomMC:master Apr 18, 2025
@WaitingIdly WaitingIdly deleted the extended-crafting-base-block branch April 18, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants