Skip to content

Fix GroovyScript crashing on servers #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brachy84 merged 4 commits into from
Mar 20, 2025
Merged

Fix GroovyScript crashing on servers #293

brachy84 merged 4 commits into from
Mar 20, 2025

Conversation

@WaitingIdly
Copy link
Collaborator

@WaitingIdly WaitingIdly commented Mar 20, 2025

changes in this PR:

  • extract java version checking to its own class to declutter the GroovyScript class.
    • add some javadocs explaining it.
  • annotate TextureBinder.drawSprite as client-only and return empty functional interfaces so the method isnt called.
  • separate the reference to the client-only class IncompatibleJavaException into its own method.

resolves #292

@WaitingIdly WaitingIdly added the bug Something isn't working label Mar 20, 2025
@brachy84 brachy84 merged commit 0a92eef into CleanroomMC:master Mar 20, 2025
@WaitingIdly WaitingIdly deleted the fix-serverside-loading branch March 21, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Version 1.2.1 crashes on server startup

2 participants

@WaitingIdly @brachy84