Fix some IDE warnings #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
accessoryTypevalidation null check promptly throwing a NPE.@NotNulland@Nullableare just before the return type instead of on the line prior.@Overrideannotations to methods missing them."".equals(String)withString#isEmpty().1.0finstead of1f).ObjectMapper.Builderhaving a field with the typeTextureBinderinstead ofTextureBinder<T>when the only way to set it is via calling the methodtextureBinder(TextureBinder<T>).@NotNullannotation to the parameter of a method in theJeiPlugin.ClassCanBeRecordwarnings, as we have decided not to use those.uncheckedwarnings for cases in which the entity class in a RecipeBuilder/removal.basically all of these are just inspection stuff, with the exception of the fixing an NPE when validating
accessoryType.