Skip to content

Conversation

@kattouf
Copy link
Contributor

@kattouf kattouf commented Apr 1, 2025

At first, I got an error when trying to use the server with the Zed editor:

error: keyNotFound(CodingKeys(stringValue: "messageActionItem", intValue: nil), Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "params", intValue: nil), CodingKeys(stringValue: "capabilities", intValue: nil), CodingKeys(stringValue: "window", intValue: nil), CodingKeys(stringValue: "showMessage", intValue: nil)], debugDescription: "No value associated with key CodingKeys(stringValue: \"messageActionItem\", intValue: nil) (\"messageActionItem\").", underlyingError: nil))

Then I checked the specification and discovered differences in optionality:

workDoneProgress?: boolean;

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#serverInitiatedProgress

property path (optional): window.showMessage
messageActionItem?: {
additionalPropertiesSupport?: boolean;

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest

property path (optional): window.showDocument

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showDocument

@kattouf kattouf changed the title make window capabilities optional make client window capabilities optional Apr 1, 2025
@mattmassicotte
Copy link
Contributor

Argh, sorry about that.

But thanks so much for finding those issues and for correcting them. I really appreciate it!

@mattmassicotte
Copy link
Contributor

(Also don't worry about CI, it's expected it has gone wrong and I'll look into that separately.)

@mattmassicotte mattmassicotte merged commit 8ff9196 into ChimeHQ:main Apr 1, 2025
0 of 3 checks passed
@kattouf kattouf deleted the fix-window-client-capabilities-optionality branch April 1, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants