Skip to content

Conversation

@FastestMolasses
Copy link
Contributor

Hello, I'm working on adding LSP support to CodeEdit. Can we get this ServerInfo struct exposed when initializing a server? It's great information to have for logging. Thanks!

@mattmassicotte
Copy link
Contributor

mattmassicotte commented Jan 28, 2024

Great idea, and thanks so much for making the PR! I totally forgot about the ServerInfo structure and had to look it up to even figure out what it was!

It got me thinking, I believe we can simplify a lot of this by just storing the InitializationResponse instead of destructuring it first and storing the fields. That's my bad design. I don't think fixing that internally is necessary, but I do think it's worthwhile fixing the publicly-facing API to reduce client churn.

@mattmassicotte
Copy link
Contributor

Oh, and I'm thrilled to see you starting on this work! Please do not be shy about questions! Also, there's been a lot of change to this repo in the last little while, and I anticipate more...

@FastestMolasses
Copy link
Contributor Author

Agreed, made the change.

Oh, and I'm thrilled to see you starting on this work! Please do not be shy about questions! Also, there's been a lot of change to this repo in the last little while, and I anticipate more...

Sounds great!

@mattmassicotte
Copy link
Contributor

This is a fantastic change, and you cleaned up all the internals too! Great stuff, thank you!

@mattmassicotte mattmassicotte merged commit 94bb1bb into ChimeHQ:main Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants