Skip to content

feat: add tooltip support for exact X & Y values on hover #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 21, 2025
Merged

feat: add tooltip support for exact X & Y values on hover #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e757421
feat: add tooltip support for exact X & Y values on hover
Winter-Soren Mar 9, 2025
34d1e11
update package-lock.json
juliangruber Mar 17, 2025
5855852
fix lint
juliangruber Mar 17, 2025
ae83792
`npm install`
juliangruber Mar 20, 2025
5580ea7
fix unit
juliangruber Mar 20, 2025
625a572
fix unit
juliangruber Mar 20, 2025
e679853
ttfb
juliangruber Mar 20, 2025
e2c594a
deduplicate
juliangruber Mar 20, 2025
7345c24
unify
juliangruber Mar 20, 2025
f4924fa
show tips for both lines
juliangruber Mar 20, 2025
7998a50
label
juliangruber Mar 20, 2025
09c6072
label
juliangruber Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/histogram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ export function Histogram(events, { width, title, thresholds }) {
y: 'count',
x: 'type',
fill: 'type',
tip: {
format: {
threshold: (v) => `Range: ${v}%`,
count: (v) => `Count: ${v} miners`,
type: true,
},
},
}),
],
y: { grid: true },
Expand Down
23 changes: 23 additions & 0 deletions src/components/line-graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ export function LineGraph(events, { width, height, title, start, end } = {}) {
})),
]

// Format functions for tooltip values
const formatDate = (d) =>
new Date(d).toLocaleDateString('en-US', {
year: 'numeric',
month: 'short',
day: 'numeric',
})
const formatPercent = (v) => (v ? `${v.toFixed(2)}%` : 'N/A')

return Plot.plot({
title,
width,
Expand All @@ -33,12 +42,26 @@ export function LineGraph(events, { width, height, title, start, end } = {}) {
y: 'success_rate',
stroke: 'type',
curve: 'linear',
tip: {
format: {
x: formatDate,
y: formatPercent,
type: true,
},
},
}),
Plot.lineY(combinedData, {
x: 'day',
y: 'success_rate_http',
stroke: 'type',
curve: 'linear',
tip: {
format: {
x: formatDate,
y: formatPercent,
type: true,
},
},
}),
],
})
Expand Down
70 changes: 62 additions & 8 deletions src/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,21 +141,43 @@ const percentiles = Object.entries(SparkMinerRsrSummaries).flatMap(
${Plot.plot({
title: '# of Filecoin SPs with a non-zero Spark Retrieval Success Rate',
x: { label: null },
y: { grid: true, label: null },
y: { grid: true, label: '# Non-Zero SPs' },
color: { legend: true },
marks: [
Plot.ruleY([0]),
Plot.line(nonZeroMinersOverTime, {
Plot.lineY(nonZeroMinersOverTime, {
x: 'day',
y: 'count_succes_rate',
stroke: "type",
curve: 'catmull-rom',
tip: {
format: {
x: d => new Date(d).toLocaleDateString('en-US', {
year: 'numeric',
month: 'short',
day: 'numeric'
}),
y: v => `${v} SPs`,
type: true
}
}
}),
Plot.line(nonZeroMinersOverTime, {
Plot.lineY(nonZeroMinersOverTime, {
x: 'day',
y: 'count_succes_rate_http',
stroke: "type",
curve: 'catmull-rom',
tip: {
format: {
x: d => new Date(d).toLocaleDateString('en-US', {
year: 'numeric',
month: 'short',
day: 'numeric'
}),
y: v => v ? `${v} SPs` : 'N/A',
type: true
}
}
})
]
})}
Expand All @@ -164,7 +186,7 @@ const percentiles = Object.entries(SparkMinerRsrSummaries).flatMap(
${Plot.plot({
title: '# of Filecoin SPs with Spark Retrieval Success Rate above x%',
x: { label: null },
y: { grid: true, label: null },
y: { grid: true, label: '# SPs above x%' },
color: {
scheme: "Paired",
legend: "swatches"
Expand All @@ -175,7 +197,18 @@ const percentiles = Object.entries(SparkMinerRsrSummaries).flatMap(
x: 'day',
y: 'count_succes_rate',
stroke: 'label',
curve: 'catmull-rom'
curve: 'catmull-rom',
tip: {
format: {
x: d => new Date(d).toLocaleDateString('en-US', {
year: 'numeric',
month: 'short',
day: 'numeric'
}),
y: v => `${v} SPs`,
label: true
}
}
})
]
})}
Expand Down Expand Up @@ -261,7 +294,7 @@ const tidy = clone(SparkRetrievalResultCodes).flatMap(({ day, rates }) => {
color: {
scheme: "Accent",
legend: "swatches",
label: "Codes"
label: "code"
},
marks: [
Plot.rectY(tidy, {
Expand All @@ -270,7 +303,18 @@ const tidy = clone(SparkRetrievalResultCodes).flatMap(({ day, rates }) => {
fill: "code",
offset: "normalize",
sort: {color: null, x: "-y" },
interval: 'day'
interval: 'day',
tip: {
format: {
x: d => new Date(d).toLocaleDateString('en-US', {
year: 'numeric',
month: 'short',
day: 'numeric'
}),
y: v => v.toFixed(2),
code: true
}
}
})
]
})}
Expand All @@ -283,12 +327,22 @@ const tidy = clone(SparkRetrievalResultCodes).flatMap(({ day, rates }) => {
${Plot.plot({
title: 'Time to First Byte (ms)',
x: { type: 'utc', ticks: 'month' },
y: { grid: true, zero: true},
y: { grid: true, zero: true, label: 'ttfb (ms)' },
marks: [
Plot.lineY(SparkRetrievalTimes, {
x: 'day',
y: 'ttfb_ms',
stroke: "#FFBD3F",
tip: {
format: {
x: d => new Date(d).toLocaleDateString('en-US', {
year: 'numeric',
month: 'short',
day: 'numeric'
}),
y: v => v.toFixed(0)
}
}
})
]
})}
Expand Down