-
Notifications
You must be signed in to change notification settings - Fork 18
Py cf client3.0 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Py cf client3.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat in other places. Editor removed whitespace and unnecessary \ at end of lines. Uncommented update tests, fixed a single error in non-update tests involving repeating a delete operation on success.
…ide-effects were handled. Moved multiple delete fix to finally clause to match other finally clauses. Fixed failing update operation tests. One outstanding test may be no longer available functionality, throws HTTP Bad Request error.
…slashes at end of lines.
…teChannel2, testUpdateProperty, and testUpdateTag. Added skip decorator to testUpdateRemoveProperty2Channel.
Links to local utility scripts not part of the project, thus should not be linked in the project file.
@Dylan171 suggested fix for url argument appended to this commit.
Conflicts: channelfinder/ChannelFinderClient.py test/ChannelFinderClientTest.py
Contributor
Author
|
@Dylan171 future issues with these changes can be addressed via new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of PR #12 for the purpose of cleaning up the .project