Skip to content

Conversation

@jacomago
Copy link
Contributor

No description provided.

@jacomago jacomago requested a review from shroffk November 24, 2023 09:19
@shroffk
Copy link
Collaborator

shroffk commented Nov 27, 2023

It is nice to see how jdk17 would help get rid of a bunch of the boiler plate...not to mention the annoying xml binding dependencies.

@shroffk
Copy link
Collaborator

shroffk commented Nov 27, 2023

trying to figure out how best to co-ordinate with all the collaborators on the move to JDK17

@jacomago jacomago force-pushed the java17 branch 5 times, most recently from 93c67c6 to 9ae8912 Compare February 5, 2024 12:56
@thelarsjohansson
Copy link
Collaborator

The "upgrade" path should be Spring Boot 2.7.18 + Java 17, before the step to Spring Boot 3 (e.g. 3.2.2) is made. In general, it's suitable and standard behavior to update so as to make the upcoming leap as small as possible.

In addition

  • Phoebus Olog already updated to Java 17
  • 2.7.18 is update of minor version only

Therefore

  • I recommend to update to Java 17 and Spring Boot 2.7.18 and use that as base for looking into Spring Boot 3.

@jacomago jacomago force-pushed the java17 branch 3 times, most recently from 4a8daff to ac04d8e Compare March 4, 2024 14:16
@jacomago jacomago force-pushed the java17 branch 2 times, most recently from a9ee857 to 9c77e7e Compare April 3, 2024 12:52
@thelarsjohansson
Copy link
Collaborator

ControlSystemStudio / phoebus and Olog / phoebus-olog have been updated to 17 (but not released thereafter).
It's logical step to do the same with ChannelFinder and allow for test and/or alpha/beta release if so desired.

If there are uncertainties, it would be useful to list those. It might be indication that specific test efforts are required.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shroffk
Copy link
Collaborator

shroffk commented Apr 23, 2024

Since we have the 4.7.3 alpha release in place I think we can merge this

@shroffk shroffk merged commit 67da02f into ChannelFinder:master Apr 23, 2024
@jacomago jacomago deleted the java17 branch April 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants