Skip to content

Conversation

@jacomago
Copy link
Contributor

@jacomago jacomago commented Oct 3, 2023

Hi @tynanford @shroffk @mdavidsaver

This is a proposal to add a new feature to the Channel Finder Archiver Appliance Processor.

The feature would automatically Pause, Resume or Archive PVs tagged with the "archive" infotag.

So in the end you would have:

 * name ArchiveStatus PVStatus - Archiver Appliance Action

 * PV Archived Active - Do Nothing
 * PV Paused Active - Resume
 * PV None Active - Archive
 * PV Archived Inactive - Pause
 * PV Paused Inactive - Nothing
 * PV None Inactive - Nothing

I need to do some more testing but I thought it would be good to get feedback on any problems there might be.

@jacomago jacomago force-pushed the archiver-pause-resume branch from f369a5d to 5c180e0 Compare October 3, 2023 15:15
@jacomago
Copy link
Contributor Author

jacomago commented Oct 4, 2023

One option is to add the possibility of pausing PVs that are being archived but are no longer being tagged.
Another is to update the policy in case the policy changes from what has been set.

@tynanford
Copy link
Contributor

Hi @jacomago , I think this makes sense but I'd like to test for a bit when you are ready to see how it works in practice. For instance, if an IOC reboots or if recceiver is rebooted then the PVs in the archiver will become paused for a little while and then resumed, I guess that is okay? Maybe a preference setting for aa_paused_on_inactive would be good to allow opting-out of this.

One concern I have is this adds a dependency on having recsync and the pvStatus fields be correct. We had some issues with this field in the past but it seems to have all been solved in your PR #106 so that concern might not be valid anymore.

Overall, having some way to update the policies, pause PVs that no longer have tags, pause Inactive PVs, etc. would be really useful. We have already seen cases at ALS where PVs get added to the archiver mistakenly and have to be manually fixed. I like the idea of pausing PVs that no longer have an archive tag in CF since otherwise those can be hard to find

@jacomago jacomago force-pushed the archiver-pause-resume branch from 5c180e0 to d57f854 Compare October 5, 2023 15:02
@jacomago
Copy link
Contributor Author

jacomago commented Oct 5, 2023

@tynanford I updated the solution to have some configuration. So now there is a configuration parameter aa.auto_pause which can be set to:

none
pvStatus
archive
pvStatus,archive

Corresponding to whether to pause on change in pvStatus, or if the archive tag exists.

@jacomago
Copy link
Contributor Author

Thought of another idea, can probably add a timeout. i.e. how long a PV is inactive before pausing. I think can use the endpoint of the archiver to detemine last time there was a connection.

@shroffk
Copy link
Collaborator

shroffk commented Oct 25, 2023

I am going to add this to the discussion topics for the next monthly developers meeting

@jacomago jacomago force-pushed the archiver-pause-resume branch from d57f854 to ac07d78 Compare November 3, 2023 09:03
@jacomago jacomago marked this pull request as ready for review November 3, 2023 09:11
@jacomago jacomago force-pushed the archiver-pause-resume branch from ac07d78 to 62094f3 Compare November 15, 2023 15:26
Adds a configuration parameter aa.auto_pause which can be set to:

none
pvStatus
archive
pvStatus,archive

Corresponding to whether to pause on change in pvStatus, or if the archive tag exists.
@jacomago jacomago force-pushed the archiver-pause-resume branch from 62094f3 to 8949ef2 Compare November 16, 2023 14:18
@shroffk shroffk merged commit dd52749 into ChannelFinder:master Nov 16, 2023
@jacomago jacomago deleted the archiver-pause-resume branch November 24, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants