Performance issue on large tables with many table cells #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
added 5 commits
November 4, 2013 16:20
| @@ -478,7 +485,20 @@ def _should_parse_next_as_content(el): | |||
| # Create the actual li element | |||
| return self.list_element(parsed) | |||
|
|
|||
| def get_tcs_in_column(self, tbl, column_index): | |||
There was a problem hiding this comment.
We should probably go back to this being _get_tcs_in_column
|
Looks good other than the minor naming change. |
jlward
added a commit
that referenced
this pull request
Nov 5, 2013
Performance issue on large tables with many table cells
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
…ter than lists (in this case)
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Performance issue on large tables with many table cells
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
…ter than lists (in this case)
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Performance issue on large tables with many table cells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table has a large number of cells then we call
find_allon that tablentimes wherenis the number of cells in the table. Add simple memoization to prevent this from happening.