If a t tag has no text then the parser throws an error. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -577,13 +577,13 @@ def _is_style_on(self, el): | |||
| return val.lower() not in DISABLED_VALUES | |||
|
|
|||
| def parse_t(self, el, parsed): | |||
| return self.escape(el.text) | |||
| return self.escape(el.text or '') | |||
There was a problem hiding this comment.
Why bother passing an empty string into escape? Does that actually do anything?
|
looks good |
jlward
added a commit
that referenced
this pull request
Jul 5, 2013
If a t tag has no text then the parser throws an error.
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
If a t tag has no text then the parser throws an error.
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
If a t tag has no text then the parser throws an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some word processors (cough abiword cough), it is possible for
ttags to have no content. It would look something like this<w:t />.When we call
parse_twe call callself.escape. If you passNoneintoself.escapean error is thrown. Ift.text is Nonethen earlyreturn ''