Skip to content

Do cleanup on insert/delete/sdt tags #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2013
Merged

Do cleanup on insert/delete/sdt tags #30

merged 4 commits into from
May 23, 2013

Conversation

jlward
Copy link
Contributor

@jlward jlward commented May 21, 2013

  • Until we actually start using them remove the author/date attributes.
  • Do not break separate insert, delete or sdt tags in lists or tables.

@jlward jlward mentioned this pull request May 21, 2013
Merged
@winhamwr
Copy link
Contributor

And when you do add them back in, I'd say they should be something like data-pdx-author and data-pdx-date

@jlward
Copy link
Contributor Author

jlward commented May 21, 2013

Also handle sdt tags as well.

@jlward jlward mentioned this pull request May 21, 2013
Merged
@winhamwr winhamwr mentioned this pull request May 21, 2013
Merged
@winhamwr
Copy link
Contributor

Looks solid.

jlward added a commit that referenced this pull request May 23, 2013
@jlward
Merge pull request #30 from OpenScienceFramework/issue_30
a061e3a 
Do cleanup on insert/delete/sdt tags
@jlward jlward merged commit a061e3a into master May 23, 2013
jlward pushed a commit that referenced this pull request Mar 14, 2014
refs #30: Updated the tests for expected behaviour
258543c
jlward pushed a commit that referenced this pull request Mar 14, 2014
refs #30: no longer adding invalid attributes to insert and delete tags
03bffe7
jlward pushed a commit that referenced this pull request Mar 14, 2014
refs #30: stopped break separating tags that were inline like (insert…
90f7b81 
…, delete, smart)
jlward added a commit that referenced this pull request Mar 14, 2014
@jlward
Merge pull request #30 from OpenScienceFramework/issue_30
e07d686 
Do cleanup on insert/delete/sdt tags
jlward pushed a commit that referenced this pull request Mar 14, 2014
refs #30: Updated the tests for expected behaviour
d568390
jlward pushed a commit that referenced this pull request Mar 14, 2014
refs #30: no longer adding invalid attributes to insert and delete tags
8af55e5
jlward pushed a commit that referenced this pull request Mar 14, 2014
refs #30: stopped break separating tags that were inline like (insert…
4d39162 
…, delete, smart)
jlward added a commit that referenced this pull request Mar 14, 2014
@jlward
Merge pull request #30 from OpenScienceFramework/issue_30
846fd86 
Do cleanup on insert/delete/sdt tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlward @winhamwr