Stop overriding the handlers in the test cases #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
added 8 commits
May 21, 2013 13:14
| .left{{text-align:left}} .comment{{color:blue}} | ||
| body{{width:%(width)spx; margin:0px auto; | ||
| }}</style>''') % { | ||
| return textwrap.dedent('<style>.insert {color:green;}.delete {color:red;text-decoration:line-through;}.center {text-align:center;}.right {text-align:right;}.left {text-align:left;}.comment {color:blue;}body {width:0px;margin:0px auto;}</style>') % { # noqa |
There was a problem hiding this comment.
Can we use a line continuation here. This is pretty rough to read/review.
|
I'll wait to review this more until #28 is merged in. |
added 3 commits
May 21, 2013 14:45
Conflicts: pydocx/parsers/Docx2Html.py pydocx/tests/test_docx.py pydocx/tests/test_xml.py
| }}</style>''') % { | ||
| result = ( | ||
| '<style>' | ||
| '.pydocx-insert {color:green;}' |
There was a problem hiding this comment.
I'm assuming that in #30 we're going to fix the indentation and spacing here.
There was a problem hiding this comment.
Wait, what's wrong with the indentation here? This is the fix.
On May 21, 2013 3:06 PM, "Wes Winham" [email protected] wrote:
In pydocx/parsers/Docx2Html.py:
@@ -21,16 +20,22 @@ def head(self):
}def style(self):
return textwrap.dedent('''<style>.insert{{color:red}}.delete{{color:red; text-decoration:line-through}}.center{{text-align:center}}.right{{text-align:right}}.left{{text-align:left}} .comment{{color:blue}}.pydocx-underline {text-decoration: underline;}body{{width:%(width)spx; margin:0px auto;}}</style>''') % {result = ('<style>''.pydocx-insert {color:green;}'I'm assuming that in #30https://github.com/OpenScienceFramework/pydocx/issues/30we're going to fix the indentation and spacing here.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/29/files#r4324013
.
|
Looks good. |
jlward
added a commit
that referenced
this pull request
May 22, 2013
Stop overriding the handlers in the test cases
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Stop overriding the handlers in the test cases
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Stop overriding the handlers in the test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That defeats the purpose. Plus it's time to stop being lazy and fully convert the tests from docx2html syntax to pydocx.