Having only one list item in the root that is not last creates invalid html #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
added 7 commits
May 16, 2013 15:41
…ml. Also updated the justification test case to generate valid html as well.
Conflicts: pydocx/tests/test_xml.py
Conflicts: pydocx/DocxParser.py
| @@ -460,10 +460,29 @@ def parse_list(self, el, text): | |||
| return self.parse_table_cell_contents(el, parsed) | |||
| return parsed | |||
|
|
|||
| def _build_list(self, el, text): | |||
| # Get the list style for the pending list. | |||
There was a problem hiding this comment.
And this actually makes the code cleaner, anyway. Nice
|
Looks good if you add a comment there. It kind of makes me think that |
added 2 commits
May 21, 2013 10:42
Conflicts: pydocx/tests/test_xml.py
jlward
added a commit
that referenced
this pull request
May 21, 2013
Having only one list item in the root that is not last creates invalid html
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
…ml. Also updated the justification test case to generate valid html as well.
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Having only one list item in the root that is not last creates invalid html
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
…ml. Also updated the justification test case to generate valid html as well.
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Having only one list item in the root that is not last creates invalid html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.