Skip to content

[ENG-8096] Admins on projects are unable to reject user access requests #11163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

[ENG-8096] Admins on projects are unable to reject user access requests #11163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a7c32
pass user permissions when reject access request
antkryt Jun 2, 2025
16aece0
don't pass permission parameter explicitly; add data default value
antkryt Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions website/static/js/accessRequestManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ var AccessRequestModel = function(accessRequest, pageOwner, isRegistration, isPa
self.respondToAccessRequest = function(trigger, data, event) {
$osf.trackClick('button', 'click', trigger + '-project-access');
$osf.block();
data = data || {};

var requestUrl = $osf.apiV2Url('actions/requests/nodes/');
var payload = self.requestAccessPayload(trigger, data.permissions, data.visible);
var request = $osf.ajaxJSON(
Expand Down
5 changes: 4 additions & 1 deletion website/templates/project/contributors.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,10 @@
visible: visible()
})}"
><i class="fa fa-plus"></i> Add</button>
<span data-bind="click: function() {respondToAccessRequest('reject')}, visible: !$root.collapsed()"><i class="fa fa-times fa-2x remove-or-reject"></i></span>
<span data-bind="click: function() {respondToAccessRequest('reject', {
visible: !$root.collapsed()
})}"
><i class="fa fa-times fa-2x remove-or-reject"></i></span>
<button class="btn btn-default btn-sm m-l-md" data-bind="click: function() {respondToAccessRequest('reject')}, visible: $root.collapsed()"><i class="fa fa-times"></i> Remove</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need something similar?

Copy link
Contributor Author

@antkryt antkryt Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current issue is that when we create requestAccessPayload, we try to access data (that we don't pass) and if it's null it throws an error on the JS side. I'll update code as you suggested, permission will be passed in any case (by default it's "read"):
self.permission = ko.observable(accessRequest.requested_permissions || 'read');

Regarding the button, it's currently disabled and not visible on the Contributors page (visible: $root.collapsed()). I'd like to remove it but I'm not sure if it's used somewhere else.

</div>
</td>
Expand Down
Loading