Skip to content

Conversation

opaduchak
Copy link
Contributor

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@opaduchak opaduchak changed the base branch from develop to feature/datacite-usage-tracker January 30, 2025 15:15
@futa-ikeda
Copy link
Contributor

Dang, looking at the build failure, it seems like the build process is looking for vanilla JS and is getting a TS file

Module build failed (from ./node_modules/ember-auto-import/node_modules/babel-loader/lib/index.js):
SyntaxError: /home/runner/work/ember-osf-web/ember-osf-web/node_modules/datacite-tracker/src/index.ts: Missing semicolon. (11:15)

   9 |     if (scriptEl) {
  10 |         // Find the DOI
> 11 |         let doi: string = ""
     |                ^
  12 |
  13 |         // Get DOI from the dataset tag always as preferred
  14 |         doi = scriptEl.dataset.doi || "";

Not sure how hard it would be to address this, but would you mind seeing if it's an easy/stable/reasonable fix?

@opaduchak opaduchak closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants