Skip to content

Conversation

@gnodar01
Copy link
Member

@gnodar01 gnodar01 commented Jan 5, 2023

Some numpy aliases were deprecated in version 1.20, and those deprecations are now expired in 1.24. This PR removes deprecated numpy scalars.

Complement to PR CellProfiler/CellProfiler#4710

@gnodar01
Copy link
Member Author

gnodar01 commented Jan 5, 2023

Pretty confused on the remaining failed test on python 3.8.

Stated reason for test failing

AttributeError: module 'numpy' has no attribute 'bool'

Location of error is in centrosome

File "centrosome/_filter.pyx", line 45, in init centrosome._filter

numpy.bool has already been replaced with just bool there in CellProfiler/centrosome#110.

We're definitely using Centrosome 1.2.1, so I don't understand where or why numpy is getting involved.

@gnodar01 gnodar01 merged commit 116da4e into master Jan 5, 2023
@gnodar01 gnodar01 deleted the np_deprecations branch January 5, 2023 17:08
gnodar01 added a commit that referenced this pull request Jan 5, 2023
* Remove deprecated numpy aliases

* Recompile centrosome
gnodar01 added a commit that referenced this pull request Jan 5, 2023
* Remove deprecated numpy aliases

* Recompile centrosome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants