#214 Fix root left padding when value is primitive #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect left padding on root-level primitive value nodes by only applying indentation when a node has a parent.
- Add conditional check on
parentDatato skip indentation at the root. - Updated inline style to use
0whenparentDataisnull.
Comments suppressed due to low confidence (1)
src/ValueNodeWrapper.tsx:349
- Consider adding a unit test or snapshot test to cover the case where
parentDataisnullto ensure the root node receives no left padding.
marginLeft: parentData !== null ? `${indent / 2}em` : 0,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #214