[CRITICAL] Game randomly crashes immediately right after pressing play

[valkyrienyanko]

The error

ERROR: FATAL: Condition "gchandle.is_released()" is true.
   at: mono_object_disposed_baseref (modules/mono/csharp_script.cpp:1770)
Fatal error. 0xC000001D
   at Godot.NativeInterop.NativeFuncs.godotsharp_internal_refcounted_disposed(IntPtr, IntPtr, Godot.NativeInterop.godot_bool)
   at Godot.GodotObject.Dispose(Boolean)
   at Godot.GodotObject.Finalize()
   at System.GC.RunFinalizers()
Godot Engine v4.4.1.stable.mono.official.49a5bc7b6 - https://godotengine.org
ERROR: System.InvalidOperationException: Handle is not initialized.
   at System.Runtime.InteropServices.GCHandle.FromIntPtr(IntPtr value)
   at Godot.Bridge.CSharpInstanceBridge.SerializeState(IntPtr godotObjectGCHandle, godot_dictionary* propertiesState, godot_dictionary* signalEventsState) in /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/CSharpInstanceBridge.cs:line 212
   at: void Godot.NativeInterop.ExceptionUtils.LogException(System.Exception) (/root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/ExceptionUtils.cs:113)
Unloading assembly load context...
Vulkan 1.4.308 - Forward+ - Using Device #0: AMD - AMD Radeon RX 6600

Steps to Reproduce

I should note I am unable to reproduce this in Template but the issue does appear in my closed source game which extends from Template so I am not sure if the issue is specifically from Template or my game.

Either way steps to reproduce are as follows:

1. Make change to some script
2. Press play
3. Repeat steps 1 to 2 until the error popup appears

What I'm trying to solve this

I noticed I'm disposing InputEvent in _Input and this is constantly being called whenever there is any input like keyboard input or mouse movement / click inputs. I also do GC.Collect() but it is unrelated since I never used that when this crash occurred, but regardless it will be removed.

Template/Framework/Scenes/MenuUI/Options/OptionsInput.cs

Line 51 in 4dfe8f7

@event.Dispose(); // Object count was increasing a lot when this function was executed

Template/Framework/Scenes/MenuUI/Options/OptionsInput.cs

Line 83 in 4dfe8f7

@event.Dispose(); // Object count was increasing a lot when this function was executed

Template/Framework/Scenes/MenuUI/Options/OptionsInput.cs

Line 264 in 4dfe8f7

GC.Collect(); // Object count was increasing a lot when this function was executed

I did this a while back because I didn't understand the GC and thought the object count increasing from this was a bad thing but then later learned that you do not touch the GC as it handles itself.

I will remove these 3 lines of code and see if the problem persists.

I'm going to assume these are the cause of the issue because when I was working in C on a separate project, double disposing anything would lead to an instant crash.

On a side note I also noticed the ImGui Godot addon calls the Dispose method a lot but I don't think that is the cause of this problem.

Update

The game crashed immediately on pressing play. I didn't have to move or do anything, it happened instantly. This was around with 4th time I pressed play.

Unloading assembly load context...
Assembly load context unloaded successfully.
Godot Engine v4.4.1.stable.mono.official.49a5bc7b6 - https://godotengine.org
Vulkan 1.4.308 - Forward+ - Using Device #0: AMD - AMD Radeon RX 6600

Hello from Example Mod by valkyrienyanko
Godot Engine v4.4.1.stable.mono.official.49a5bc7b6 - https://godotengine.org
ERROR: FATAL: Condition "gchandle.is_released()" is true.
   at: mono_object_disposed_baseref (modules/mono/csharp_script.cpp:1770)
Fatal error. 0xC000001D
   at Godot.NativeInterop.NativeFuncs.godotsharp_internal_refcounted_disposed(IntPtr, IntPtr, Godot.NativeInterop.godot_bool)
   at Godot.GodotObject.Dispose(Boolean)
   at Godot.GodotObject.Finalize()
   at System.GC.RunFinalizers()
ERROR: System.InvalidOperationException: Handle is not initialized.
   at System.Runtime.InteropServices.GCHandle.FromIntPtr(IntPtr value)
   at Godot.Bridge.CSharpInstanceBridge.SerializeState(IntPtr godotObjectGCHandle, godot_dictionary* propertiesState, godot_dictionary* signalEventsState) in /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/CSharpInstanceBridge.cs:line 212
   at: void Godot.NativeInterop.ExceptionUtils.LogException(System.Exception) (/root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/ExceptionUtils.cs:113)
Unloading assembly load context...
Vulkan 1.4.308 - Forward+ - Using Device #0: AMD - AMD Radeon RX 6600

Update

Looks like the problem may be caused by this line.

Template/Framework/Autoloads/ModLoader.cs

Line 21 in 4dfe8f7

using DirAccess dir = DirAccess.Open(modsPath);

I do not think we are suppose to dispose DirAccess.Open like this and no where in the code do I do dir.ListDirEnd();

Removing the using and adding dir.ListDirEnd(); at the very end of the LoadMods() function seems to have solved the issue.

https://docs.godotengine.org/en/stable/classes/class_diraccess.html

Looks like they use using in the docs. So I will try calling dir.Dispose() right after dir.ListDirEnd().

Looks like this solved the issue? Not getting the crash anymore.

[valkyrienyanko]

Problem came back.

Popup Title: Godot_v4.4.1-stable_mono_win64.exe - EXCEPTION
Popup Description: Illegal Instruction An attempt was made to execute an illegal instruction.
Popup Button: OK

According to ChatGPT, static events are not cleaned up and live on when the game closes.

So in light of this I will be turning all static events into instance events or explicitly setting them to null when the game stops in _ExitTree()

Hopefully this solves the crash?

Edit: I'm not sure why GPT said this because I created an MRP with testing what it said and static events were cleaned up on every game restart so looks like GPT has no idea what it is talking about.

[valkyrienyanko]

Looks like misuse of static events were the culprit! All static events have been removed from the project and the error seems to have gone away for good now!

[valkyrienyanko]

The issue has come back in my own game and I don't use static events anywhere. At least I'm pretty sure I don't.

[valkyrienyanko]

Here is what Windows Event Viewer says

Application: Godot_v4.4.1-stable_mono_win64.exe
CoreCLR Version: 9.0.725.31616
.NET Version: 9.0.7
Description: The process was terminated due to an internal error in the .NET Runtime at IP 0x00007FFD37069302 (0x00007FFD36D80000) with exit code 0xc000001d.

I have set rendering/rendering_device/driver.windows to d3d12 as a user says switching to this driver fixed their issue.. Hopefully this fixes my issue as well.

Keeping this issue closed as I was only able to reproduce it on my closed source game and not this template repo. Note that my game used this template as a base so it may be related.