Skip to content

Update: Officers API #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Update: Officers API #121

wants to merge 31 commits into from

Conversation

jbriones1
Copy link
Contributor

@jbriones1 jbriones1 commented Sep 29, 2025 •
edited
Loading

Tests

  • added Webmaster test db entries for easier testing
  • refactored the test fixtures so they can be re-used
  • fixed some warnings that would become errors in the future
  • this patch breaks the elections tests, but will be fixed afterwards
  • broke down the Officer units tests into smaller tests

Officer

  • closes REST api for officers #2: updated the officers API for basic CRUD usage
  • updated the HTTP decorators to update the documentation
  • added appropriate models

Officer Term

Elections

  • the datetime fields should be timezone unaware now
  • we may need to update old timestamps to this time

@jbriones1
wip: add webmaster data to test DB
98ad852
@jbriones1
wip: add officer models and update GET current officer docs
2ae6aea
@jbriones1
wip: get current officers done
14cef35
@jbriones1
feat: Migration for Elections and Officers
af9e464 
- closes #71: Added unique constraint Officer Term
- Changed TIMESTAMP to DATETIME on Elections table
@jbriones1
fix: update election type max length to 32
c3130b0
@jbriones1
fix: elections and officers datetime to DATE
c554946
@jbriones1
fix: update officer term constraint migration
1a5a3c1
@jbriones1
fix: fix lint errors in constraint update
777948c
@jbriones1
wip: removed some unused imports and updated some constraints
ce28f15
@jbriones1
wip: update GET all officers
ab736be
@jbriones1
wip: update Officer models
223f1e5
@jbriones1
fix: site users couldn't have NULL log in time
b59fffd
@jbriones1
wip: add endpoint information for officer terms and officer info POST
d817743
@jbriones1
wip: PATCH officer term and officer info done
75f6644
@jbriones1
wip: DELETE officer term works
c9b561b
@jbriones1
fix: return to timezone unaware datetimes
87bf0d5
@jbriones1
fix: election timestamps back to datetime
0892540
@jbriones1
wip: GET all officers dynamically shows fields
422617b
@jbriones1
fix: lint issues
30785b9
@jbriones1
wip: get current officers works
8c7f4be
@jbriones1
test: Suppress SQLAlchemy logs and marked tests WIP
c9673d2 
- Discord, GitHub, and Google tests marked WIP
- Suppressed SQLAlchemy logs when tests are running
- Added a global fixture to set up the database (wip)
@jbriones1
fix: suppress asyncio warning
f3ac5ac
@jbriones1
wip: refactored the unit test fixtures to the configuration file
f39c994
@jbriones1
fix: change database set up to once per module
f5c8796
@jbriones1
fix: unit tests working with only one set up
c93ea35
@jbriones1
fix: event loop fixed
86435f8
@jbriones1
wip: add admin_client
8e17f27
@jbriones1
fix: unit tests split up and all pass
1502065
@jbriones1 jbriones1 marked this pull request as ready for review October 6, 2025 18:37
@jbriones1 jbriones1 requested a review from p-north October 6, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-north p-north Awaiting requested review from p-north

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return whether deletion succeeded or not Officer profile information REST api for officers

1 participant

@jbriones1