Skip to content

Conversation

@aborgna-q
Copy link
Collaborator

Closes #2185, by shifting the responsibility to the user.

It also helps greatly reduce payload size, as we don't encode the prelude extension anymore :)

@aborgna-q aborgna-q requested a review from ss2165 May 9, 2025 15:26
@aborgna-q aborgna-q requested a review from a team as a code owner May 9, 2025 15:26
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (0f78fab) to head (a065ee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
- Coverage   81.97%   81.97%   -0.01%     
==========================================
  Files         229      229              
  Lines       39948    39930      -18     
  Branches    36047    36029      -18     
==========================================
- Hits        32749    32734      -15     
+ Misses       5371     5368       -3     
  Partials     1828     1828              
Flag Coverage Δ
python 85.64% <ø> (ø)
rust 81.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented May 9, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_variant_missing.ron

Failed in:
variant PackageValidationError::MissingExtension, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-core/src/package.rs:135

@aborgna-q aborgna-q added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 2bfeaae May 9, 2025
26 of 27 checks passed
@aborgna-q aborgna-q deleted the ab/package-no-default-exts branch May 9, 2025 15:43
This was referenced May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package does not store transitively required extensions

4 participants