Issue #580 #602
Merged
Issue #580 #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlptp
force-pushed
the
invalid_name_error
branch
from
1d3c964 to
f317c53
Compare
phlptp
force-pushed
the
invalid_name_error
branch
from
f317c53 to
c72d2a0
Compare
henryiii
approved these changes
Jun 17, 2021
github-actions
bot
added
needs changelog
henryiii
removed
needs README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with Issue #580
Look into the issue and make the error messages a little clearer in the case.
The incorrectConstruction will still throw an error. But the error message should contain a little more information on what the exact issue is.
At some point in the future it might be worth adding some code to allow additional characters in the subcommands and option names on a configurable basis. I don't think we can allow any others by default though.