Skip to content

Conversation

@henryiii
Copy link
Collaborator

@henryiii henryiii commented Dec 28, 2020

This makes "MakeSingleFiles" explicitly controlled by "magic comments". This provides enough freedom to work on the optional pre-compile mode, which otherwise would require significantly more advanced logic to pull off automatically when merging files - this should keep it manageable.

Comments look like this: // [CLI11:<name>:<action>], where action starts with verbatim or set, and ends with end. The names are then available to be used in a .in file. I've kept the script mostly general in design, though we have CLI11 specific defaults in it.

Maybe we should move the CLI11.hpp.in file somewhere other than the main dir?

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #546 (24ddfb9) into master (822f3d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #546   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         3780      3780           
=========================================
  Hits          3780      3780           
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <ø> (ø)
include/CLI/Config.hpp 100.00% <ø> (ø)
include/CLI/ConfigFwd.hpp 100.00% <ø> (ø)
include/CLI/Error.hpp 100.00% <ø> (ø)
include/CLI/Formatter.hpp 100.00% <ø> (ø)
include/CLI/FormatterFwd.hpp 100.00% <ø> (ø)
include/CLI/Option.hpp 100.00% <ø> (ø)
include/CLI/Split.hpp 100.00% <ø> (ø)
include/CLI/StringTools.hpp 100.00% <ø> (ø)
include/CLI/TypeTools.hpp 100.00% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822f3d6...24ddfb9. Read the comment docs.

@henryiii henryiii force-pushed the henryiii-py branch 2 times, most recently from 00a430c to 71765b3 Compare December 31, 2020 00:15
@henryiii henryiii marked this pull request as ready for review December 31, 2020 01:03
@henryiii henryiii requested a review from phlptp December 31, 2020 01:04
@henryiii henryiii merged commit f862849 into master Jan 4, 2021
@henryiii henryiii deleted the henryiii-py branch January 4, 2021 22:47
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jan 4, 2021
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Mar 4, 2021
@henryiii henryiii added this to the v2.0 milestone Jun 24, 2021
@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants