This repository was archived by the owner on Dec 20, 2023. It is now read-only.
add php 7.2 to hypernode-vagrant #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also see previous #184 Note that the box file doesn't contain all required PHP modules for now, we use this box for building those in our CI. We will be gradually adding the required modules as soon as we've compiled and tested them for the new version.
fixes
```
Failures:
1) VagrantHypconfigmgmt::Command#get_options_string when the options are floats it casts the floats to strings and returns them separated by 'or'
Failure/Error: expect( subject.get_options_string([5.5, 5.6, 7.0, 7.1]) ).to eq("5.5 or 5.6 or 7.0 or 7.1 or 7.2")
expected: "5.5 or 5.6 or 7.0 or 7.1 or 7.2"
got: "5.5 or 5.6 or 7.0 or 7.1"
(compared using ==)
# ./spec/unit/command/get_options_string_spec.rb:37:in `block (4 levels) in <top (required)>'
Finished in 0.13202 seconds (files took 0.27398 seconds to load)
98 examples, 1 failure
```
fixes:
```
FAIL: test_parse_start_runner_arguments_errors_when_php72_and_precise (tests.unit.hypernode_vagrant_runner.commands.test_parse_start_runner_arguments.TestParseStartRunnerArguments)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/ByteInternet/hypernode-vagrant/tools/hypernode-vagrant-runner/tests/unit/hypernode_vagrant_runner/commands/test_parse_start_runner_arguments.py", line 173, in test_parse_start_runner_arguments_errors_when_php72_and_precise
self.argument_parser.return_value.error.assert_called_once_with(ANY)
File "/home/travis/build/ByteInternet/hypernode-vagrant/tools/hypernode-vagrant-runner/venv/local/lib/python2.7/site-packages/mock/mock.py", line 947, in assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'error' to be called once. Called 0 times.
```
Member
Author
https://rubygems.org/gems/vagrant-hypconfigmgmt/versions/0.0.11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also see previous #184
Note that the box file doesn't contain all required PHP modules for now, we use this box for building those in our CI. We will be gradually adding the required modules as soon as we've compiled and tested them for the new version.
Looks like: