fix: allow method chaining for all functions #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdgroot
approved these changes
Feb 20, 2024
Member
tdgroot
left a comment
tdgroot
left a comment
There was a problem hiding this comment.
That's a breaking change, but for easier configuration I think this makes sense
Contributor
Author
|
Yeah correct 😄 I don't see any classes overwriting these methods in this repository though. I wonder if this is going to be a large breaking change for customers. If you think so updating this with a new major release somewhere in the future would be nice at least 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only a few functions return self, updated all functions in Configuration.php to return self instead of void