Skip to content

Brancher: Allow providing data for create method #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdgroot merged 1 commit into from
Nov 23, 2022
Merged

Brancher: Allow providing data for create method #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Service/BrancherApp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,19 @@
class BrancherApp extends AbstractService
{
/**
* Create an brancher app for given parent app.
* Create a brancher app for given parent app.
*
* @param string $app Name of the parent app
* @param array|null $data Extra data to be provided
* @return string Name of the brancher app
* @throws HypernodeApiClientException
* @throws HypernodeApiServerException
*/
public function create(string $app): string
public function create(string $app, ?array $data = null): string
{
$url = sprintf(App::V2_APP_BRANCHER_URL, $app);

$response = $this->client->api->post($url);
$response = $this->client->api->post($url, [], $data ? json_encode($data) : null);

$this->client->maybeThrowApiExceptions($response);

Expand Down
26 changes: 26 additions & 0 deletions tests/unit/Service/BrancherAppTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,32 @@ public function testCreateBrancherApp()
$this->assertEquals('johndoe-eph123456', $brancherAppName);
}

public function testCreateBrancherAppWithData()
{
$this->responses->append(
new Response(200, [], json_encode([
'name' => 'johndoe-eph123456',
'parent' => 'johndoe',
'type' => 'brancher',
])),
);

$brancherAppName = $this->client->brancherApp->create(
'johndoe',
['labels' => ['mybranchernode', 'mylabel=myvalue']]
);

$request = $this->responses->getLastRequest();
$this->assertEquals('POST', $request->getMethod());
$this->assertEquals('/v2/app/johndoe/brancher/', $request->getUri());
$this->assertEquals('johndoe-eph123456', $brancherAppName);
$this->assertJson((string)$request->getBody());
$this->assertEquals(
['labels' => ['mybranchernode', 'mylabel=myvalue']],
json_decode((string)$request->getBody(), true)
);
}

public function testCreateBrancherAppRaisesClientExceptions()
{
$badRequestResponse = new Response(400, [], json_encode([
Expand Down