Skip to content

Add option to append labels instead of overwrite #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdgroot merged 1 commit into from
Apr 5, 2023
Merged

Add option to append labels instead of overwrite #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Service/BrancherApp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,22 @@ public function create(string $app, ?array $data = null): string
*
* @param string $name Name of the Brancher node
* @param array $data Data to be updated
* @param bool $appendLabels Whether to append labels or to overwrite
* @return array Updated data
* @throws HypernodeApiClientException
* @throws HypernodeApiServerException
*/
public function update(string $name, array $data): array
public function update(string $name, array $data, bool $appendLabels = false): array
{
$url = sprintf(App::V2_BRANCHER_DETAIL_URL, $name);

if ($appendLabels) {
$originHypernode = substr($name, 0, strrpos($name, '-'));
$existingLabels = $this->list($originHypernode)[0]['labels'] ?? [];
foreach (explode('&', http_build_query($existingLabels)) as $label) {
$data['labels'][] = $label;
}
}

$response = $this->client->api->put($url, [], json_encode($data));

Expand Down