Many EoF weapons' socketEntries do not have plugSources set (i.e. plugSources:0)

[rslifka]

Hiyooo it appears that many of the socket.socketEntries[] for EoF weapons do not have their plugSources values set (they're all set to 0).

One example is Agape.

The perk information is of course present in the GetProfile response, but I need help from the manifest to know where to look 😄

Let me know if you'd like me to catalog all the new weapons set like this. I figured you might have some tools that let you do it more efficiently than I would, but if not I'm happy to make a list!

[aadam-bng]

We're investigating; what use case are you using plugSources for? The possible plugs for a socket are still available in the randomized PlugSet

[rslifka]

I use plugSources to tell me where in the response to look for what perks rolled on the weapon instance based on the API docs 😄 To your point, the randomizedPlugSetHash can tell us what is possible, but plugSources tells us where to look to see what actually happened.

Indicates how a socket is populated, and where you should look for valid plug data.

E.g. sockets, reusablePlugs, profilePlugSets, ...

...and once you know that, you know:

1. What /GetProfile components to request (so that the data you need is available)
2. Where in the /GetProfile response should you look.

My app (Vault Zero) is closed sourced, but I'm happy to add you to the repo if you want to see the logic and tests that cover the various cases! (that offer goes for anyone at Bungie)

[aadam-bng]

If you're looking for what perks rolled on a weapon, you can use the item instance and its BnetDestinyItemSocketsComponent to find out what the current state of the socket is, and the BnetDestinyItemReusablePlugsComponent for that particular socket index

[rslifka]

Not all sockets are present in BnetDestinyItemReusablePlugsComponent, some are only present in profilePlugSets and characterPlugSets. plugSources tells you which of these sources to combine.

Stepping back, does plugSources:0 mean:

1. "The manifest doesn't have this information, so you'll have to find it yourself."
2. "There are no perks that can roll in this slot (e.g. earlier iterations of weapons that have no origin traits)."
3. "We haven't yet updated plugSources on these items."

In the interim, it sounds like you're suggesting the following algorithm:

1. Check BnetDestinyItemReusablePlugsComponent.
2. Check resuablePlugSetHash entry in characterPlugSets (if one is specified in the socketEntry)
3. Check resuablePlugSetHash entry in profilePlugSets (if one is specified in the socketEntry)
4. Check sockets (because only one perk rolled in that column).

I'm happy to implement this algorithm of course! Just lmk 😄

[justrealmilk]

If you're looking for what perks rolled on a weapon, you can use the item instance and its BnetDestinyItemSocketsComponent to find out what the current state of the socket is, and the BnetDestinyItemReusablePlugsComponent for that particular socket index

The plugSources property dictates where to collect plugs from. That's the bug.

[justrealmilk]

Fundamentally broken

From Collections in game for a weapon I do not own. This is called the collections roll.

What we get after processing sockets and plugs in the same way we have been

[justrealmilk]

This is what we usually get

From Collections

Check out what we get from the defs for Nullify

initial plug hash (collections roll) and correctly set sources

[justrealmilk]

Weirdly, Nullify's singleInitialItemHash for its Barrel is Corkscrew Rifling in game but Chambered Compensator in defs

...

Just checked weapons from as far back as King's Fall and their initial hashes also don't match their in game counterparts anymore :|

[rslifka]

@aadam-bng Shoot, was hoping the update today would do the trick but alas - plugSources:0 :(

Let me know if there's anything I can do to help! / check on / validate, etc.