fix: Fix incorrect interpreting strings with $ as env vars #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this bug where any string with a dollar sign
$is being treated as env var and then fails when trying to load such env var. Saw the problem is the regex is missing an anchor at startˆ. Adding this will make sure value needs to start with$and not randomly in middle of string.Example of failure:
When trying to load with config parser:
I've added unit tests to cover this scenario
diosil1@root python-config-parser % python test_configparser.py ............ ---------------------------------------------------------------------- Ran 12 tests in 0.002s OK@BrunoSilvaAndrade please review this?