Add initial open note-link functionality #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on BoostIO/BoostNote-App#691 Changes pulled in from original patch: - Update db API for creating a note link (createstore, FSNoteDb) - Add codemirror hyperlink addon - Initialize hyperlink addon (CodeMirror.ts) - Add event handling of editor ctrl+click link with ipc (App.tsx) - Add regexes for note link shortId (MarkdownPreviewer.tsx) - Add handling of rendering and clicking of note link in md preview - Fix electron only API - Fix getWebContentsById to be initialized - Fix hyperlink to use electron only API - Fix macos binding in hyperlink - Refactor utility functions and put regexes in constants - Fix note linking when title contains characters that should be escaped - Add note link copied push message - Add push message when note link is successfully copied - Fix issues with event default propagation on context menu Differences from original patch: - Removed PouchNoteDb support - Migrated to V2 API for context menu in sidebar - Removed codemirror hyperlink addon css style (CodeEditor.tsx) Co-authored-by: Elliot Miller <[email protected]> Co-authored-by: Komediruzecki <[email protected]>
|
Hi, thanks for the contribution, will inspect and resolve this tomorrow, so we can have note linking in the next release. |
Add cross storage note linking Fix notification type on success for note link copy
|
Hi, I've made some small changes:
Tested the feature, works really nice, so I think we can merge it. |
Awesome! Thanks for doing this, especially with such a quick turnaround! Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I pulled in the changes that @Komediruzecki had originally proposed in BoostIO/BoostNote-App#691.
I updated the patch for all the recent changes, including moving the context menu from the old API to V2.
Preview
This preview is from testing with the local development setup.
Detailed Changelog