Skip to content

Fix person-questions_sets-array #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OfTheDelmer merged 21 commits into from
Sep 14, 2015
Merged

Fix person-questions_sets-array #39

OfTheDelmer merged 21 commits into from
Sep 14, 2015

Conversation

@OfTheDelmer
Copy link
Contributor

@OfTheDelmer OfTheDelmer commented Sep 14, 2015

Editing out comments

John Backus and others added 21 commits September 8, 2015 11:50
Add rspec-its to gemspec
9911cf2 
Currently devtools is adding the rspec-its dependency, but only for rubies
>= 2.1, so we add our own explicit dependency in our gemspec for earlier rubies
Update FactoryGirl dependency to 4.5
0e68afa
Refactor out different id string fakers to method
760433a
Add question_set_count option to person factory
553c52b 
Lets you specify how many question set ids should come with the
person resource you are creating
@OfTheDelmer
Add fixes related to question sets
223a8a5 
Update the collections with instance methods that proxy to the target
class, and lazy load embedded parent data in for the target.

fixes #36, #35, #34, #22
@OfTheDelmer
Add formatting changes
bdc3c82 
Used rubocop autofix on lib and spec directories
@OfTheDelmer
Add merge to lazy loaded attributes with current
db03f71
@OfTheDelmer
Add houndci comment suggestions
089e5db
@OfTheDelmer
Add changes to address PR comments
0cd4706 
See
https://github.com/BlockScore/blockscore-ruby/pull/23/files#r38977260
@OfTheDelmer
Refactor public default_params method
6ccdac4 
See
223a8a5#commitcomment-13121687
@OfTheDelmer
Add houndci formatting for spec
4102fa3
Add documentation for collection
153a26f 
- Moved a few attributes into protected/private in the process.
- Also changed `data` to be a method in collection
Refactor minor style and naming in collection
b546473 
- renamed `target` to `member_class`
- renamed `data` to `ids`
- changed Collection to use positional args instead of a hash
[WIP] Add collection member class
68a8968
@OfTheDelmer
Add #saved? to base and spec
f43d11f
@OfTheDelmer
Add initial changes for spec refactor
a4dd8e1 
Refactors specs related to collection from question sets to separate
spec and moves some member related specs out of collection specs. Still
requires more specs on Member to raise mutant coverage. It also renames
the Base#saved? to Base#persisted?.
@OfTheDelmer
Add README updated testing instructions
fc05a5b
@OfTheDelmer
Add member spec and bug fixes related to Base#id
999a725
Refactor a few specs in member_spec
969e450
@OfTheDelmer
Update version
59b6a29
@OfTheDelmer
Remove comments
ffb5320 
There was a comment in base.rb that needed removal
@OfTheDelmer
Copy link
Contributor Author

OfTheDelmer commented Sep 14, 2015

Files reviewed for extraneous comments, LGTM.

OfTheDelmer added a commit that referenced this pull request Sep 14, 2015
@OfTheDelmer
Merge pull request #39 from BlockScore/fix/person-question_sets-array
a0ddc70 
Fix person-questions_sets-array
@OfTheDelmer OfTheDelmer merged commit a0ddc70 into master Sep 14, 2015
@sirwolfgang sirwolfgang deleted the fix/person-question_sets-array branch September 14, 2015 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OfTheDelmer @backus