Fix/person question sets array

[backus]

Failing test for issue mentioned in #22. Good to go @DelmerGA

[houndci-bot]

Style/CollectionMethods: Prefer map over collect.

[houndci-bot]

Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

[houndci-bot]

Style/SpaceInsideBlockBraces: Space missing inside }.

[houndci-bot]

Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

[houndci-bot]

Style/SpaceInsideBlockBraces: Space missing inside {.

[backus]

pry

[backus]

In general we try to follow the best practices for rspec. Mainly I'd recommend checking out https://github.com/howaboutwe/rspec-style-guide http://betterspecs.org/. A few specific points I would point out:

1. Prefer short describes, short its, and long contexts. Usually describe and it will just be a constant name or a method description like '.foo' or '#bar'. Same for it minus the constant. This isn't a strict rule since sometimes it is hard to avoid, but in general this is preferable and it also factors into how mutant works with your specs

2. Similar to the note above, feel free to omit it descriptions when possible. For example:

   describe '#all' do
     subject { collection.all  }
   
     it 'should return self' do
       is_expected.to be(collection)
     end
   end

   vs.

   describe '#all' do
     subject { collection.all }
     it { should be(collection) }
   end

3. You can name your subjects like so:

   subject(:foo) { something_else.get_foo }

   This way a spec like the following

   subject { collection.create }
   
   it 'should retrieve item from registered' do
     found_qs = collection.retrieve(subject.id)
     expect(subject).to eq(found_qs)
   end

   could be

   subject(:member) { collection.create }
   
   it 'should retrieve item from registered' do
     found_qs = collection.retrieve(member.id)
     expect(subject).to eq(found_qs)
   end

   which I think is much more readable

[houndci-bot]

Style/Documentation: Missing top-level module documentation comment.

[OfTheDelmer]

LGTM