Changes based on style and lint checks. (final_code_quality_9) #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
fd8d6a8 to
8d33f3c
Compare
PeterSurda
requested changes
Oct 12, 2018
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
8d33f3c to
e3cc167
Compare
g1itch
reviewed
Oct 19, 2018
| port = 8444 | ||
| announceInterval = 60 | ||
|
|
||
| def __init__(self, host=None, sock=None, announcing=False): | ||
| super(BMProto, self).__init__(sock=sock) | ||
| super(UDPSocket, self).__init__(sock=sock) |
There was a problem hiding this comment.
Did you test? This may be the __init__ of AdvancedDispatcher or ObjectTracker.
There was a problem hiding this comment.
Nice catch, this needs to be tested due to multiple inheritance.
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
e3cc167 to
9bc9748
Compare
coffeedogs
changed the title
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
9bc9748 to
cfdf8a0
Compare
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
cfdf8a0 to
5e9c07a
Compare
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
5e9c07a to
e05b49d
Compare
…to be completed in the future. (final_code_quality_9)
coffeedogs
force-pushed
the
final_code_quality_9
branch
from
e05b49d to
643c657
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes based on style and lint checks. (final_code_quality_9)