Changes based on style and lint checks. Some empty docstrings remain to be completed in the future. (final_code_quality_9)

Author: coffeedogs

src/bitmessageqt/addressvalidator.py

@@ -1,14 +1,30 @@
-from PyQt4 import QtGui
+"""
+src/bitmessageqt/addressvalidator.py
+====================================
+"""
+# pylint: disable=too-many-branches,too-many-arguments
 from Queue import Empty
 
-from addresses import decodeAddress, addBMIfNotPresent
+from PyQt4 import QtGui
+
 from account import getSortedAccounts
-from queues import apiAddressGeneratorReturnQueue, addressGeneratorQueue
+from addresses import addBMIfNotPresent, decodeAddress
+from queues import addressGeneratorQueue, apiAddressGeneratorReturnQueue
 from tr import _translate
 from utils import str_chan
 
-class AddressPassPhraseValidatorMixin():
-    def setParams(self, passPhraseObject=None, addressObject=None, feedBackObject=None, buttonBox=None, addressMandatory=True):
+
+class AddressPassPhraseValidatorMixin(object):
+    """"""
+    def setParams(
+            self,
+            passPhraseObject=None,
+            addressObject=None,
+            feedBackObject=None,
+            buttonBox=None,
+            addressMandatory=True):
+        """"""
+        # pylint: disable=too-many-arguments
         self.addressObject = addressObject
         self.passPhraseObject = passPhraseObject
         self.feedBackObject = feedBackObject
@@ -19,6 +35,7 @@ def setParams(self, passPhraseObject=None, addressObject=None, feedBackObject=No
         self.okButtonLabel = self.buttonBox.button(QtGui.QDialogButtonBox.Ok).text()
 
     def setError(self, string):
+        """"""
         if string is not None and self.feedBackObject is not None:
             font = QtGui.QFont()
             font.setBold(True)
@@ -31,9 +48,14 @@ def setError(self, string):
             if string is not None and self.feedBackObject is not None:
                 self.buttonBox.button(QtGui.QDialogButtonBox.Ok).setText(_translate("AddressValidator", "Invalid"))
             else:
-                self.buttonBox.button(QtGui.QDialogButtonBox.Ok).setText(_translate("AddressValidator", "Validating..."))
+                self.buttonBox.button(
+                    QtGui.QDialogButtonBox.Ok).setText(
+                        _translate(
+                            "AddressValidator",
+                            "Validating..."))
 
     def setOK(self, string):
+        """"""
         if string is not None and self.feedBackObject is not None:
             font = QtGui.QFont()
             font.setBold(False)
@@ -45,7 +67,8 @@ def setOK(self, string):
             self.buttonBox.button(QtGui.QDialogButtonBox.Ok).setEnabled(True)
             self.buttonBox.button(QtGui.QDialogButtonBox.Ok).setText(self.okButtonLabel)
 
-    def checkQueue(self):
+    def checkQueue(self):  # pylint: disable=inconsistent-return-statements
+        """"""
         gotOne = False
 
         # wait until processing is done
@@ -64,21 +87,28 @@ def checkQueue(self):
             else:
                 gotOne = True
 
-        if len(addressGeneratorReturnValue) == 0:
+        if not addressGeneratorReturnValue:
             self.setError(_translate("AddressValidator", "Address already present as one of your identities."))
             return (QtGui.QValidator.Intermediate, 0)
+
         if addressGeneratorReturnValue[0] == 'chan name does not match address':
-            self.setError(_translate("AddressValidator", "Although the Bitmessage address you entered was valid, it doesn\'t match the chan name."))
+            self.setError(
+                _translate(
+                    "AddressValidator",
+                    "Although the Bitmessage address you entered was valid, it doesn\'t match the chan name."))
             return (QtGui.QValidator.Intermediate, 0)
+
         self.setOK(_translate("MainWindow", "Passphrase and address appear to be valid."))
 
     def returnValid(self):
+        """"""
         if self.isValid:
             return QtGui.QValidator.Acceptable
-        else:
-            return QtGui.QValidator.Intermediate
+        return QtGui.QValidator.Intermediate
 
     def validate(self, s, pos):
+        """"""
+        # pylint: disable=unused-argument
         if self.addressObject is None:
             address = None
         else:
@@ -105,9 +135,13 @@ def validate(self, s, pos):
 
             # version too high
             if decodeAddress(address)[0] == 'versiontoohigh':
-                self.setError(_translate("AddressValidator", "Address too new. Although that Bitmessage address might be valid, its version number is too new for us to handle. Perhaps you need to upgrade Bitmessage."))
+                self.setError(
+                    _translate(
+                        "AddressValidator",
+                        "Address too new. Although that Bitmessage address might be valid, its version number is"
+                        " too new for us to handle. Perhaps you need to upgrade Bitmessage."))
                 return (QtGui.QValidator.Intermediate, pos)
-    
+
             # invalid
             if decodeAddress(address)[0] != 'success':
                 self.setError(_translate("AddressValidator", "The Bitmessage address is not valid."))
@@ -122,23 +156,29 @@ def validate(self, s, pos):
         if address is None:
             addressGeneratorQueue.put(('createChan', 4, 1, str_chan + ' ' + str(passPhrase), passPhrase, False))
         else:
-            addressGeneratorQueue.put(('joinChan', addBMIfNotPresent(address), str_chan + ' ' + str(passPhrase), passPhrase, False))
+            addressGeneratorQueue.put(
+                ('joinChan', addBMIfNotPresent(address),
+                 str_chan + ' ' + str(passPhrase),
+                 passPhrase, False))
 
         if self.buttonBox.button(QtGui.QDialogButtonBox.Ok).hasFocus():
             return (self.returnValid(), pos)
-        else:
-            return (QtGui.QValidator.Intermediate, pos)
+        return (QtGui.QValidator.Intermediate, pos)
 
     def checkData(self):
+        """"""
         return self.validate("", 0)
 
+
 class AddressValidator(QtGui.QValidator, AddressPassPhraseValidatorMixin):
+    """"""
     def __init__(self, parent=None, passPhraseObject=None, feedBackObject=None, buttonBox=None, addressMandatory=True):
         super(AddressValidator, self).__init__(parent)
         self.setParams(passPhraseObject, parent, feedBackObject, buttonBox, addressMandatory)
 
 
 class PassPhraseValidator(QtGui.QValidator, AddressPassPhraseValidatorMixin):
+    """"""
     def __init__(self, parent=None, addressObject=None, feedBackObject=None, buttonBox=None, addressMandatory=False):
         super(PassPhraseValidator, self).__init__(parent)
         self.setParams(parent, addressObject, feedBackObject, buttonBox, addressMandatory)

src/bitmessageqt/blacklist.py

@@ -1,18 +1,26 @@
+"""
+src/bitmessageqt/blacklist.py
+=============================
+"""
+
 from PyQt4 import QtCore, QtGui
-from tr import _translate
-import l10n
+
 import widgets
 from addresses import addBMIfNotPresent
 from bmconfigparser import BMConfigParser
 from dialogs import AddAddressDialog
 from helper_sql import sqlExecute, sqlQuery
 from retranslateui import RetranslateMixin
-from utils import avatarize
+from tr import _translate
 from uisignaler import UISignaler
+from utils import avatarize
 
 
 class Blacklist(QtGui.QWidget, RetranslateMixin):
+    """"""
+    # pylint: disable=too-many-instance-attributes
     def __init__(self, parent=None):
+        # pylint: disable=no-member
         super(Blacklist, self).__init__(parent)
         widgets.load('blacklist.ui', self)
 
@@ -21,7 +29,7 @@ def __init__(self, parent=None):
         QtCore.QObject.connect(self.radioButtonWhitelist, QtCore.SIGNAL(
             "clicked()"), self.click_radioButtonWhitelist)
         QtCore.QObject.connect(self.pushButtonAddBlacklist, QtCore.SIGNAL(
-        "clicked()"), self.click_pushButtonAddBlacklist)
+            "clicked()"), self.click_pushButtonAddBlacklist)
 
         self.init_blacklist_popup_menu()
 
@@ -30,14 +38,15 @@ def __init__(self, parent=None):
             "itemChanged(QTableWidgetItem *)"), self.tableWidgetBlacklistItemChanged)
 
         # Set the icon sizes for the identicons
-        identicon_size = 3*7
+        identicon_size = 3 * 7
         self.tableWidgetBlacklist.setIconSize(QtCore.QSize(identicon_size, identicon_size))
 
         self.UISignalThread = UISignaler.get()
         QtCore.QObject.connect(self.UISignalThread, QtCore.SIGNAL(
             "rerenderBlackWhiteList()"), self.rerenderBlackWhiteList)
 
     def click_radioButtonBlacklist(self):
+        """"""
         if BMConfigParser().get('bitmessagesettings', 'blackwhitelist') == 'white':
             BMConfigParser().set('bitmessagesettings', 'blackwhitelist', 'black')
             BMConfigParser().save()
@@ -46,6 +55,7 @@ def click_radioButtonBlacklist(self):
             self.rerenderBlackWhiteList()
 
     def click_radioButtonWhitelist(self):
+        """"""
         if BMConfigParser().get('bitmessagesettings', 'blackwhitelist') == 'black':
             BMConfigParser().set('bitmessagesettings', 'blackwhitelist', 'white')
             BMConfigParser().save()
@@ -54,7 +64,8 @@ def click_radioButtonWhitelist(self):
             self.rerenderBlackWhiteList()
 
     def click_pushButtonAddBlacklist(self):
-        self.NewBlacklistDialogInstance = AddAddressDialog(self)
+        """"""
+        self.NewBlacklistDialogInstance = AddAddressDialog(self)  # pylint: disable=attribute-defined-outside-init
         if self.NewBlacklistDialogInstance.exec_():
             if self.NewBlacklistDialogInstance.labelAddressCheck.text() == \
                     _translate("MainWindow", "Address is valid."):
@@ -68,7 +79,7 @@ def click_pushButtonAddBlacklist(self):
                     sql = '''select * from blacklist where address=?'''
                 else:
                     sql = '''select * from whitelist where address=?'''
-                queryreturn = sqlQuery(sql,*t)
+                queryreturn = sqlQuery(sql, *t)
                 if queryreturn == []:
                     self.tableWidgetBlacklist.setSortingEnabled(False)
                     self.tableWidgetBlacklist.insertRow(0)
@@ -88,24 +99,29 @@ def click_pushButtonAddBlacklist(self):
                         sql = '''INSERT INTO whitelist VALUES (?,?,?)'''
                     sqlExecute(sql, *t)
                 else:
-                    self.statusBar().showMessage(_translate(
-                        "MainWindow", "Error: You cannot add the same address to your list twice. Perhaps rename the existing one if you want."))
+                    self.statusBar().showMessage(
+                        _translate(
+                            "MainWindow",
+                            "Error: You cannot add the same address to your list twice."
+                            " Perhaps rename the existing one if you want."))
             else:
                 self.statusBar().showMessage(_translate(
                     "MainWindow", "The address you entered was invalid. Ignoring it."))
 
     def tableWidgetBlacklistItemChanged(self, item):
+        """"""
         if item.column() == 0:
             addressitem = self.tableWidgetBlacklist.item(item.row(), 1)
             if isinstance(addressitem, QtGui.QTableWidgetItem):
                 if self.radioButtonBlacklist.isChecked():
                     sqlExecute('''UPDATE blacklist SET label=? WHERE address=?''',
-                            str(item.text()), str(addressitem.text()))
+                               str(item.text()), str(addressitem.text()))
                 else:
                     sqlExecute('''UPDATE whitelist SET label=? WHERE address=?''',
-                            str(item.text()), str(addressitem.text()))
+                               str(item.text()), str(addressitem.text()))
 
     def init_blacklist_popup_menu(self, connectSignal=True):
+        """"""
         # Popup menu for the Blacklist page
         self.blacklistContextMenuToolbar = QtGui.QToolBar()
         # Actions
@@ -132,9 +148,10 @@ def init_blacklist_popup_menu(self, connectSignal=True):
         self.tableWidgetBlacklist.setContextMenuPolicy(
             QtCore.Qt.CustomContextMenu)
         if connectSignal:
-            self.connect(self.tableWidgetBlacklist, QtCore.SIGNAL(
-                'customContextMenuRequested(const QPoint&)'),
-                        self.on_context_menuBlacklist)
+            self.connect(
+                self.tableWidgetBlacklist,
+                QtCore.SIGNAL('customContextMenuRequested(const QPoint&)'),
+                self.on_context_menuBlacklist)
         self.popMenuBlacklist = QtGui.QMenu(self)
         # self.popMenuBlacklist.addAction( self.actionBlacklistNew )
         self.popMenuBlacklist.addAction(self.actionBlacklistDelete)
@@ -146,6 +163,7 @@ def init_blacklist_popup_menu(self, connectSignal=True):
         self.popMenuBlacklist.addAction(self.actionBlacklistSetAvatar)
 
     def rerenderBlackWhiteList(self):
+        """"""
         tabs = self.parent().parent()
         if BMConfigParser().get('bitmessagesettings', 'blackwhitelist') == 'black':
             tabs.setTabText(tabs.indexOf(self), _translate('blacklist', 'Blacklist'))
@@ -176,9 +194,11 @@ def rerenderBlackWhiteList(self):
 
     # Group of functions for the Blacklist dialog box
     def on_action_BlacklistNew(self):
+        """"""
         self.click_pushButtonAddBlacklist()
 
     def on_action_BlacklistDelete(self):
+        """"""
         currentRow = self.tableWidgetBlacklist.currentRow()
         labelAtCurrentRow = self.tableWidgetBlacklist.item(
             currentRow, 0).text().toUtf8()
@@ -195,17 +215,20 @@ def on_action_BlacklistDelete(self):
         self.tableWidgetBlacklist.removeRow(currentRow)
 
     def on_action_BlacklistClipboard(self):
+        """"""
         currentRow = self.tableWidgetBlacklist.currentRow()
         addressAtCurrentRow = self.tableWidgetBlacklist.item(
             currentRow, 1).text()
         clipboard = QtGui.QApplication.clipboard()
         clipboard.setText(str(addressAtCurrentRow))
 
     def on_context_menuBlacklist(self, point):
+        """"""
         self.popMenuBlacklist.exec_(
             self.tableWidgetBlacklist.mapToGlobal(point))
 
     def on_action_BlacklistEnable(self):
+        """"""
         currentRow = self.tableWidgetBlacklist.currentRow()
         addressAtCurrentRow = self.tableWidgetBlacklist.item(
             currentRow, 1).text()
@@ -223,6 +246,7 @@ def on_action_BlacklistEnable(self):
                 str(addressAtCurrentRow))
 
     def on_action_BlacklistDisable(self):
+        """"""
         currentRow = self.tableWidgetBlacklist.currentRow()
         addressAtCurrentRow = self.tableWidgetBlacklist.item(
             currentRow, 1).text()
@@ -238,5 +262,5 @@ def on_action_BlacklistDisable(self):
                 '''UPDATE whitelist SET enabled=0 WHERE address=?''', str(addressAtCurrentRow))
 
     def on_action_BlacklistSetAvatar(self):
+        """"""
         self.window().on_action_SetAvatar(self.tableWidgetBlacklist)
-