Caas 325 cleanup

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x]
+        node-version: [18.x, 20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -94,10 +94,10 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.sha }}
 
-      - name: Setup node 18
+      - name: Setup node 24
         uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
         with:
-          node-version: 18
+          node-version: 24
 
       - name: restore lerna dependencies
         id: lerna-cache
@@ -106,7 +106,7 @@ jobs:
           path: |
             node_modules
             modules/*/node_modules
-          key: ${{ runner.os }}-node18-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('package.json') }}
+          key: ${{ runner.os }}-node24-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('package.json') }}
 
       - name: Install Packages
         if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
@@ -142,10 +142,10 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.sha }}
 
-      - name: Setup node 18
+      - name: Setup node 24
         uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
         with:
-          node-version: 18 # this just needs to pass our lock file requirement for compilation
+          node-version: 24 # this just needs to pass our lock file requirement for compilation
 
       - name: Build Info
         run: |

.github/workflows/publish.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
         with:
-          node-version: 18
+          node-version: 24
 
       - name: Install BitGoJS
         run: yarn install --with-frozen-lockfile

.nvmrc

@@ -1 +1 @@
-22.16.0
+v24.3.0

DEVELOPERS.md

@@ -180,7 +180,7 @@ Engines should be set to the following:
 ```json
 {
   "engines": {
-    "node": ">=18 <23",
+    "node": ">=18 < 25",
     "npm": ">=3.10.10"
   }
 }

Dockerfile

@@ -2,7 +2,7 @@
 # An elaborated scheme to build all the dependencies of all packages first in a cached layer
 # https://stackoverflow.com/a/63142468/134409
 # https://medium.com/@emilefugulin/building-a-sane-docker-image-for-typescript-lerna-and-prisma-2-76d8ff9926e4
-FROM node:22.16.0-bookworm-slim@sha256:2f3571619daafc6b53232ebf2fcc0817c1e64795e92de317c1684a915d13f1a5 AS filter-packages-json
+FROM node:24.3.0-bookworm-slim@sha256:dd773e49e639dafc0b425bf9ac1d74705086b9aebac960706ab146c5dfa0b32d AS filter-packages-json
 LABEL maintainer="Developer Relations <[email protected]>"
 
 COPY package.json yarn.lock lerna.json ./
@@ -12,7 +12,7 @@ COPY modules ./modules
 # delete all the non package.json files under `./modules/`
 RUN find modules \! -name "package.json" -mindepth 2 -maxdepth 2 -print | xargs rm -rf
 
-FROM node:22.16.0-bookworm-slim@sha256:2f3571619daafc6b53232ebf2fcc0817c1e64795e92de317c1684a915d13f1a5 AS builder
+FROM node:24.3.0-bookworm-slim@sha256:dd773e49e639dafc0b425bf9ac1d74705086b9aebac960706ab146c5dfa0b32d AS builder
 RUN apt-get update && apt-get install -y git python3 make g++ libtool autoconf automake
 WORKDIR /tmp/bitgo
 COPY --from=filter-packages-json /tmp/bitgo .
@@ -31,7 +31,7 @@ RUN \
     rm -r modules/*/src
 
 
-FROM node:22.16.0-bookworm-slim@sha256:2f3571619daafc6b53232ebf2fcc0817c1e64795e92de317c1684a915d13f1a5
+FROM node:24.3.0-bookworm-slim@sha256:dd773e49e639dafc0b425bf9ac1d74705086b9aebac960706ab146c5dfa0b32d
 RUN apt-get update && apt-get install -y tini
 # copy the root node_modules to the bitgo-express parent node_modules
 COPY --from=builder /tmp/bitgo/node_modules  /var/node_modules/

README.md

@@ -51,7 +51,7 @@ BitGoJS currently provides support for the following Node versions per package.j
 
 ```
 "engines": {
-  "node": ">=18 <23",
+  "node": ">=18 <24",
   "npm": ">=3.10.10"
 }
 ```
@@ -62,6 +62,8 @@ As each Node LTS version reaches its end-of-life we will exclude that version fr
 
 - `18`
 - `20`
+- `22`
+- `24`
 
 JavaScript package managers should allow you to install this package with any version of Node, with, at most, a warning if your version of Node does not fall within the range specified by our node engines property. If you encounter issues installing this package on a supported version of Node, please report the issue to us.
 

examples/js/sui/custom-tx/.nvmrc

@@ -1 +1 @@
-22.16.0
+v24.3.0

examples/ts/proxy/.nvmrc

@@ -1 +1 @@
-22.16.0
+v24.3.0

examples/ts/tss-recovery/.nvmrc

@@ -1 +1 @@
-22.16.0
+v24.3.0

examples/ts/tss-smc/.nvmrc

@@ -1 +1 @@
-22.16.0
+v24.3.0

modules/abstract-cosmos/package.json

@@ -16,7 +16,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=18 <23"
+    "node": ">=18 < 25"
   },
   "repository": {
     "type": "git",

modules/abstract-eth/package.json

@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=18 <23"
+    "node": ">=18 < 25"
   },
   "repository": {
     "type": "git",

modules/abstract-eth/test/unit/token.ts

@@ -1,6 +1,10 @@
-import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
+import * as sdkTest from '@bitgo/sdk-test';
+import type { TestBitGoAPI } from '@bitgo/sdk-test';
+
 import { BitGoAPI } from '@bitgo/sdk-api';
 
+const { TestBitGo } = sdkTest;
+
 export function runTokenTestInitialization(
   currentCoinToken,
   coinName: string,

modules/abstract-lightning/package.json

@@ -17,7 +17,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=18 <23"
+    "node": ">=18 < 25"
   },
   "repository": {
     "type": "git",

modules/abstract-substrate/package.json

@@ -16,7 +16,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <23"
+    "node": ">=14 < 25"
   },
   "repository": {
     "type": "git",

modules/abstract-utxo/package.json

@@ -20,7 +20,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=18 <23"
+    "node": ">=18 < 25"
   },
   "repository": {
     "type": "git",

modules/account-lib/package.json

@@ -24,7 +24,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "ISC",
   "engines": {
-    "node": ">=18 <23"
+    "node": ">=18 < 25"
   },
   "dependencies": {
     "@bitgo/sdk-coin-ada": "^4.12.1",

modules/account-lib/test/unit/fixtures.ts

@@ -1,26 +1,22 @@
 import { BaseCoin } from '@bitgo/statics';
-import {
-  BaseMessage,
-  BaseMessageBuilder,
-  BaseMessageBuilderFactory,
-  IMessage,
-  IMessageBuilder,
-  MessageOptions,
-  MessageStandardType,
-} from '@bitgo/sdk-core';
+import * as sdkCore from '@bitgo/sdk-core';
+import type { IMessage, IMessageBuilder, MessageOptions } from '@bitgo/sdk-core';
+const { BaseMessage, BaseMessageBuilder, BaseMessageBuilderFactory, MessageStandardType } = sdkCore;
+
+type MessageStandardTypeValue = (typeof MessageStandardType)[keyof typeof MessageStandardType];
 
 export class MockMessageBuilderFactory extends BaseMessageBuilderFactory {
   constructor(coinConfig: Readonly<BaseCoin>) {
     super(coinConfig);
   }
 
-  getMessageBuilder(type: MessageStandardType): IMessageBuilder {
+  getMessageBuilder(type: MessageStandardTypeValue): IMessageBuilder {
     return new MockMessageBuilder(this.coinConfig, type);
   }
 }
 
 export class MockMessageBuilder extends BaseMessageBuilder {
-  constructor(coinConfig: Readonly<BaseCoin>, type: MessageStandardType = MessageStandardType.UNKNOWN) {
+  constructor(coinConfig: Readonly<BaseCoin>, type: MessageStandardTypeValue = MessageStandardType.UNKNOWN) {
     super(coinConfig, type);
   }
 

modules/babylonlabs-io-btc-staking-ts/package.json

@@ -27,7 +27,7 @@
     "btc-staking"
   ],
   "engines": {
-    "node": ">=18 < 23"
+    "node": ">=18 < 25"
   },
   "author": "Babylon Labs Ltd.",
   "license": "SEE LICENSE IN LICENSE",

modules/bitgo/package.json

@@ -16,7 +16,7 @@
   },
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=18 <23",
+    "node": ">=18 < 25",
     "npm": ">=3.10.10"
   },
   "scripts": {
@@ -26,14 +26,14 @@
     "webpack-dev": "cross-env NODE_ENV=development webpack",
     "webpack-prod": "NODE_OPTIONS=--max-old-space-size=4096 cross-env NODE_ENV=production webpack",
     "test": "npm run coverage",
-    "unit-test": "mocha 'test/v2/unit/**/*.ts' 'test/unit/**/*.ts'",
+    "unit-test": "mocha 'dist/test/v2/unit/**/*.js' 'dist/test/unit/**/*.js'",
     "coverage": "nyc -- npm run unit-test",
     "integration-test": "nyc -- mocha \"test/v2/integration/**/*.ts\"",
     "browser-test": "karma start karma.conf.js",
     "lint": "eslint --quiet .",
     "audit": "if [ \"$(npm --version | cut -d. -f1)\" -ge \"6\" ]; then npm audit; else echo \"npm >= 6 required to perform audit. skipping...\"; fi",
     "clean": "rm -r dist/*",
-    "build": "yarn tsc --build --incremental --verbose .",
+    "build": "yarn tsc --build --incremental --verbose . && cpx \"test/v2/unit/internal/tssUtils/ecdsaMPCv2/fixtures/**/*\" dist/test/v2/unit/internal/tssUtils/ecdsaMPCv2/fixtures",
     "prepare": "npm run build",
     "prepublishOnly": "npm run compile",
     "upload-artifacts": "node scripts/upload-test-reports.js",
@@ -145,6 +145,7 @@
     "@types/jasmine": "^3.5.12",
     "@types/lodash": "^4.14.121",
     "aws-sdk": "^2.1155.0",
+    "cpx": "^1.5.0",
     "io-ts-types": "^0.5.16",
     "karma": "^5.1.1",
     "karma-chrome-launcher": "^3.1.0",

modules/bitgo/test/ecdh.ts

@@ -8,7 +8,7 @@ import * as utxolib from '@bitgo/utxo-lib';
 
 import { getSharedSecret, signMessageWithDerivedEcdhKey, verifyEcdhSignature } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';
-import * as assert from 'assert';
+import assert from 'assert';
 import { BitGo } from '../src/bitgo';
 
 describe('ECDH utils', () => {

modules/bitgo/test/integration/wallets.ts

@@ -14,7 +14,7 @@ const TestBitGo = require('../lib/test_bitgo');
 import * as utxolib from '@bitgo/utxo-lib';
 import { getAddressP2PKH, getNetwork } from '../../src/bitcoin';
 import { common } from '@bitgo/sdk-core';
-import * as nock from 'nock';
+import nock from 'nock';
 
 const TEST_WALLET_LABEL = 'wallet management test';
 

modules/bitgo/test/unit/bip32path.ts

@@ -2,7 +2,7 @@
  * @prettier
  */
 import 'should';
-import { bip32, BIP32Interface } from '@bitgo/utxo-lib';
+import { bip32, type BIP32Interface } from '@bitgo/utxo-lib';
 import { sanitizeLegacyPath, bitcoin } from '@bitgo/sdk-core';
 import { getSeed } from '@bitgo/sdk-test';
 const { HDNode, hdPath } = bitcoin;

modules/bitgo/test/unit/bitgo.ts

@@ -3,9 +3,9 @@
 //
 
 import * as crypto from 'crypto';
-import * as nock from 'nock';
+import nock from 'nock';
 import * as should from 'should';
-import assert = require('assert');
+import assert from 'assert';
 
 import { common, generateGPGKeyPair } from '@bitgo/sdk-core';
 import { bip32, ECPair } from '@bitgo/utxo-lib';

modules/bitgo/test/unit/decryptKeychain.ts

@@ -1,5 +1,5 @@
 import 'should';
-import { decryptKeychainPrivateKey, OptionalKeychainEncryptedKey } from '@bitgo/sdk-core';
+import { decryptKeychainPrivateKey, type OptionalKeychainEncryptedKey } from '@bitgo/sdk-core';
 import { BitGoAPI } from '@bitgo/sdk-api';
 
 describe('decryptKeychainPrivateKey', () => {

modules/bitgo/test/unit/keychains.ts

@@ -3,7 +3,7 @@
 //
 
 import * as _ from 'lodash';
-import * as nock from 'nock';
+import nock from 'nock';
 import 'should';
 
 import { common } from '@bitgo/sdk-core';

modules/bitgo/test/v2/integration/coins/eth.ts

@@ -2,7 +2,7 @@ import * as should from 'should';
 import 'should-http';
 
 import { TestBitGo } from '../../../lib/test_bitgo';
-import * as nock from 'nock';
+import nock from 'nock';
 nock.restore();
 
 describe('ETH:', function () {

modules/bitgo/test/v2/integration/coins/xlm.ts

@@ -4,7 +4,7 @@ import { BaseCoin } from '../../../../src/v2';
 
 import { TestBitGo } from '../../../lib/test_bitgo';
 
-import * as nock from 'nock';
+import nock from 'nock';
 
 describe('XLM:', function () {
   let bitgo: typeof TestBitGo;

modules/bitgo/test/v2/integration/wallet.ts

@@ -4,7 +4,7 @@
 
 import * as should from 'should';
 import * as _ from 'lodash';
-import * as nock from 'nock';
+import nock from 'nock';
 
 import { TestBitGo } from '../../lib/test_bitgo';
 

modules/bitgo/test/v2/lib/recovery-nocks.ts

@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import * as nock from 'nock';
+import nock from 'nock';
 import { Environments } from '@bitgo/sdk-core';
 
 module.exports.nockXrpRecovery = function nockXrpRecovery() {

modules/bitgo/test/v2/unit/PrebuildAndSign.ts

@@ -1,5 +1,5 @@
 import * as sinon from 'sinon';
-import * as nock from 'nock';
+import nock from 'nock';
 
 import { Environments, Wallet } from '@bitgo/sdk-core';
 import { TestableBG, TestBitGo } from '@bitgo/sdk-test';

modules/bitgo/test/v2/unit/accountConsolidations.ts

@@ -6,13 +6,13 @@ import * as sinon from 'sinon';
 require('should-sinon');
 
 import '../lib/asserts';
-import * as nock from 'nock';
+import nock from 'nock';
 
 import { common, Wallet } from '@bitgo/sdk-core';
 
 import { TestBitGo } from '@bitgo/sdk-test';
 import { BitGo } from '../../../src/bitgo';
-const algoFixtures = require('../../../../sdk-coin-algo/test/fixtures/algo');
+const algoFixtures = require('../../../../../sdk-coin-algo/test/fixtures/algo');
 
 nock.disableNetConnect();
 

modules/bitgo/test/v2/unit/ams/ams.ts

@@ -1,5 +1,5 @@
 import * as should from 'should';
-import * as nock from 'nock';
+import nock from 'nock';
 
 import { Environments } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';

modules/bitgo/test/v2/unit/apiNocks.ts

@@ -1,4 +1,4 @@
-import * as nock from 'nock';
+import nock from 'nock';
 
 export async function nockGetSigningKey(params: {
   userId: string;

modules/bitgo/test/v2/unit/auth.ts

@@ -1,4 +1,4 @@
-import * as nock from 'nock';
+import nock from 'nock';
 import 'should';
 import * as sinon from 'sinon';