forked from Azure/azure-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
Update 5/7 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update 5/7 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z staticwebapp create; az staticwebapp update (#17870) * Add sku option for staticwebapp create and change staticwebapp browse to staticwebappshow * add method update_staticsites * add unit tests * Code Clean up * pass code style checking * remove f1 and s1 as sku option * remove build_propertes, resource_group, location from az staticwebapp option * revised app_artifact_location to output_location * pass code style chekcing * minor revision for unit tests * pass empty string to clear tags in staticwebapp update * Update src/azure-cli/azure/cli/command_modules/appservice/_params.py fix typo Co-authored-by: Feiyue Yu <[email protected]> * Resolve PR comments * remove browse instead of deprecating it to pass linter Co-authored-by: Feiyue Yu <[email protected]>
* Customer reported bug fix * Removed _packing_engine changes * Re-recorded test cases with template specs * Reviewer suggestion * pylint supression added for broad-except * Added explanation for changes in code and updated logic Co-authored-by: Dania Etienne <[email protected]>
…n failure (#17867) * 'CLIupdateartifactto0.6.0' * add notebook test required changes * add rg preparer * remove unused name * refine form of line indent * remove unused parts * update records
* [Compute] sig image version create: Support data disk VHDs * data disks VHDs * test * test * style * fix a small bug * update * test
* Made AFS Configure Backup Idempotent * cli style check * cli style fix
* update azure-cli version to 2.23.0 * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Apply suggestions from code review Co-authored-by: Feng Zhou <[email protected]> Co-authored-by: kai ru <[email protected]> * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Apply suggestions from code review * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Fix webapp Co-authored-by: Feiyue Yu <[email protected]> Co-authored-by: xfz11 <[email protected]> Co-authored-by: Yishi Wang <[email protected]> Co-authored-by: Feng Zhou <[email protected]> Co-authored-by: kai ru <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>
…rivate network access (#17767) * remove capital letter in generated role name * fix typo in tests * private DNS zone create * Address resource id formats * fixed style issues * add links * test fixed with private dns zone updates * add private dns zone create tests * style issue fixed * enable database name when creating db server * add check name availability and tests * change mysql default storage size * upgrade rdbms version * azdev style test fixed * help text added * add subnet verifying bug fix * improve help text * fixed typo * change from 8.0.1b3 to 8.0.1b4 * trigger CI CD
…17916) * {EventGrid}: Add tests to commands introduced in 2020-10-15-preview * Fix style errors + remove secret * Remove secret
…valid 'end' argument #17988
…king slotsetting to true (#17895) * fix:az cli update app setting command always making slotsetting to true * Fixed build failed issue.
…sonal access token (#17826) * Get github token thru browser * Add comments * Use url way instead of opening browser * Fix linter issues * CLI linter fixes * Add PyGithub package for github actions use later on (it will be in CLI extensions repo) and github_action property in az webapp deployment source config command * add PyGithub to setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.