neuroml: do not use "is" with strings #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works, but only because of an implementation detail: short strings are interned as part of module code. But the rules are complicated and we should not rely on this. See http://guilload.com/python-string-interning/ for a nice writeup. Python3.8 now warns about this.
dilawar
approved these changes
Sep 27, 2019
Contributor
dilawar
left a comment
dilawar
left a comment
There was a problem hiding this comment.
Thanks for the heads up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but only because of an implementation detail: short
strings are interned as part of module code. But the rules are complicated
and we should not rely on this.
See http://guilload.com/python-string-interning/ for a nice writeup.
Python3.8 now warns about this.