fix: Preserve world transform on graph parenting #606
+78
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still edge-cases but it's a good start. |
julien-moreau
requested changes
Sep 5, 2025
| private _setParentPreservingWorldTransform(node: Node, newParent: Node | null): void { | ||
| if (!(node instanceof TransformNode)) { | ||
| // For non-transform nodes, just set the parent directly | ||
| node.parent = newParent; |
There was a problem hiding this comment.
I think we should manage for lights and cameras too, that they don't extend TransformNode
There was a problem hiding this comment.
That's good suggestion. I used Copilot, I will properly test is during the weekend
yuripourre
force-pushed
the
fix-graph-parenting
branch
from
9281914 to
2e13582
Compare
yuripourre
force-pushed
the
fix-graph-parenting
branch
from
9ff135a to
ba773a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Preserve world transform on graph parenting
Summary
When assigning a node to another node, it's world transformation is not persisted, so the child node has it's position, rotation and scaled modified relatively to it's the parent, this is not desirable and sometimes you have no idea where the node went after assigning a parent.
Changes Made
Introduced _setParentPreservingWorldTransform
In the graph we added a new method that assigns a parent and preserves world transform.
Benefits